Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCPCLOUD-1865] Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 into master #38

Merged
merged 44 commits into from Feb 2, 2023
Merged

[OCPCLOUD-1865] Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 into master #38

merged 44 commits into from Feb 2, 2023

Conversation

cloud-team-rebase-bot[bot]
Copy link

No description provided.

@openshift-ci openshift-ci bot requested review from JoelSpeed and lobziik May 12, 2022 12:20
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 12, 2022

Hi @cloud-team-rebase-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Karthik-K-N Karthik-K-N mentioned this pull request May 16, 2022
Merged
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch 2 times, most recently from d1279d6 to ed0d419 Compare June 9, 2022 12:18
@elmiko
Copy link

elmiko commented Jun 13, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2022
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch 2 times, most recently from df7b8d6 to 5b946b1 Compare June 20, 2022 12:14
@Fedosin
Copy link

Fedosin commented Jun 22, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 22, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch 2 times, most recently from 114a6ec to d531f44 Compare June 30, 2022 12:20
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch 2 times, most recently from a8a4fae to 6aa08a6 Compare August 1, 2022 12:21
@elmiko
Copy link

elmiko commented Sep 1, 2022

@JoelSpeed @Fedosin should we merge this?

@elmiko
Copy link

elmiko commented Jan 30, 2023

/title [OCPCLOUD-1865] Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 into master

@elmiko
Copy link

elmiko commented Jan 30, 2023

updated the branch to 1.26 from the upstream with this openshift/release#35795

we should get the latest when this PR merges

@elmiko
Copy link

elmiko commented Jan 30, 2023

/retitle [OCPCLOUD-1865] Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 into master

@openshift-ci openshift-ci bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.24 into master [OCPCLOUD-1865] Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 into master Jan 30, 2023
@elmiko
Copy link

elmiko commented Jan 30, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2023
@elmiko
Copy link

elmiko commented Jan 30, 2023

/retest

@iksrochpub
Automated repo sync 20230131
3be43ac 
Return 1 if no tagging is done (#3184)
@elmiko
Copy link

elmiko commented Jan 31, 2023

looks like we need to update to use a golang 1.19 image for building here

@elmiko elmiko mentioned this pull request Jan 31, 2023
Merged
@elmiko
Copy link

elmiko commented Jan 31, 2023

this will need openshift/release#35890 to pass the CI

iksrochpub and others added 10 commits February 2, 2023 04:00
@iksrochpub
Automated repo sync 20230202
cd79097 
Branch release-1.26 CCM image updated (#3185)
merge upstream/release-1.26 into master
3d3c228
@Fedosin
UPSTREAM: <carry>: Add OWNERS
1fd39bf 
(cherry picked from commit f210a1d)
@Fedosin
UPSTREAM: <carry>: Add vendor/
33a892b 
(cherry picked from commit c03bf4f)
@Fedosin
UPSTREAM: <carry>: Add a Dockerfile that compatible with OpenShift
c936cc0
UPSTREAM: <carry>: Updating ose-ibm-cloud-controller-manager images t…
cdcbf9e 
…o be consistent with ART

Squashed:
fab1cc0
396acfb
672425c
@lobziik
UPSTREAM: <drop>: Updating and vendoring go modules after an upstream…
5d8d2a4 
… rebase
UPSTREAM: <carry>: Updating ose-ibm-cloud-controller-manager images t…
85d7b9e 
…o be consistent with ART

Reconciling with https://github.com/openshift/ocp-build-data/tree/61541c1c730569d20db98c885bb07d7ee96e648c/images/ose-ibm-cloud-controller-manager.yml
@JoelSpeed
UPSTREAM: <carry>: Sync OWNERS file
06916e2
UPSTREAM: <carry>: Updating and vendoring go modules after an upstrea…
52cb105 
…m rebase
@elmiko
Copy link

elmiko commented Feb 2, 2023

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2023

@cloud-team-rebase-bot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial 6ac9f5b link true /test e2e-aws-serial
ci/prow/e2e-ibmcloud 52cb105 link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elmiko
Copy link

elmiko commented Feb 2, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit 70fe86a into openshift:master Feb 2, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@lobziik lobziik Awaiting requested review from lobziik

Assignees

@elmiko elmiko

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@elmiko @Fedosin @JoelSpeed @openshift-ci-robot @lobziik @openshift-merge-robot @iksrochpub