Add spec and Dockerfile for the CD integration #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertinatto
reviewed
Sep 5, 2018
images/manila-provisioner/Dockerfile
Outdated
| io.k8s.description="This is a component of OpenShift Container Platform which allows to provision persistent volumes using OpenStack Manila API." \ | ||
| io.openshift.tags="openshift,manila,openstack" | ||
|
|
||
| CMD /usr/bin/manila-provisioner |
There was a problem hiding this comment.
Since [1] accepts some CLI options, e.g., kubeconfig, would it make sense to use ENTRYPOINT instead?
I think CMD will be overwritten when the container is run with arguments [2].
[1] https://github.com/openshift/cloud-provider-openstack/blob/master/cmd/manila-provisioner/main.go
[2] https://docs.docker.com/engine/reference/builder/#understand-how-cmd-and-entrypoint-interact
There was a problem hiding this comment.
You're right. I copied another Dockerfile and didn't realize mine is slightly different...
tsmetana
force-pushed
the
ose-cd-integration
branch
from
754e85f
to
7ebce02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the spec file and Docker file to add Manila provisioner rpm/image builds to the OpenShift CD managment.
@childsb PTAL, I'm asking this to be merged to release-3.11 branch.