Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #124

Merged
merged 32 commits into from Jul 5, 2022
Merged

Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #124

merged 32 commits into from Jul 5, 2022

Conversation

shiftstack-merge-bot[bot]
Copy link

No description provided.

jichenjc and others added 10 commits May 9, 2022 02:01
@jichenjc
switch to node-role.kubernetes.io/control-plane (kubernetes#1840)
babbb06
@chrigl
[cinder-csi-plugin] Add doc for volume expansion (kubernetes#1852)
ef17e2b 
In the past I saw this question bubbling up several times and it is hard
to find an good answer on the internet.

Signed-off-by: Christoph Glaubitz <c.glaubitz@syseleven.de>
@jichenjc
add sec group logic for octavia (kubernetes#1836)
8e56242
@chrigl
[ci] Replace golint and gofmt by golangci-lint (kubernetes#1860)
4f0b050 
Because golint is deprecated we need to replace it by something else.
golangci-lint seems like a good fit, because it supports a wide viarity
of lintes/checkers. It is also possible to use golangci-lint in IDEs,
VS Code for example includes it by default (while it needs to be enabled).
@jichenjc
Add jichen as co-leader (kubernetes#1867)
9910e2c
@zetaab
Add Github Actions release pipeline (kubernetes#1870)
0e5df93 
* add gha

* allow alpha tags and remove dist

* update process

* rename file
@shaardie
Fix for Authentication Dependencies for Application Credentials (kube…
7dc229c 
…rnetes#1854)

This patch extend the authentication configuration by the possibility to use
application credentials.

fix_auth_dependencies_for_application_credentials

Signed-off-by: Sven Haardiek <sven.haardiek@uni-muenster.de>
@chrigl
[cinder-csi-plugin] move cinder-csi-e2e to e2e.test (kubernetes#1869)
cbf7420 
This PR removes the old cinder-csi-e2e testsuite and replaces it by
upstream e2e.test. We need this, so that the testsuite has access to
testfiles, embedded in e2e.test since v1.24.
@zetaab
fix on push tags (kubernetes#1872)
7ea8ddc
@zetaab
read version from github ref (kubernetes#1873)
8a6d7e7
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 19, 2022

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2022
@EmilienM
Copy link
Member

/lgtm
/approve
/hold for CI

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2022
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 19, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 23, 2022
@chrigl
Refactor pkg/util to improve codeclimate (kubernetes#1884)
7761946 
This is the first of a series of refactorings to improve codeclimate.
Made changes to pkg/utils to make golangci-lint and revive happy. One
suggestion was to rename MetadataOpts to Opts, because caller would use
it ad metatada.MetadataOpts what is redundand. For backward
compatibility all exported types are aliased to the new ones.
@chrigl
Refactor identity components to improve code climate (kubernetes#1888)
4ff3420 
This commit includes the components client-keystone-auth and
k8s-keystone-auth, which both use pkg/identity.
jichenjc and others added 4 commits June 22, 2022 00:43
@jichenjc
update release procedure file (kubernetes#1927)
9ce648e
@jichenjc
update csi external container release (kubernetes#1895)
a0e4fe6
@fmount
Improve manila csi driver chart adding fsGroupPolicy (kubernetes#1894)
39da03d 
The fsGroupPolicy option can now be defined per protocol,
enforcing a different behavior to the driver [1]

[1] https://kubernetes-csi.github.io/docs/support-fsgroup.html

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@chrigl
Enable default golangci-lint + revive (kubernetes#1892)
d45f3db 
After cleaning up code, this commit enables golangci-lint checks
including revive, to ensure code climate on each PR.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@mandre
Copy link
Member

mandre commented Jun 27, 2022

/retest

@mandre
Copy link
Member

mandre commented Jun 28, 2022

The failing tests in openstack-csi-cinder job all succeeded individually in separate runs.
The e2e-openstack failure also looks like flake.
/retest

@EmilienM
Copy link
Member

/lgtm
/hold for ci

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jun 30, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, shiftstack-merge-bot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM
Copy link
Member

/hold cancel
results are acceptable to me

@mandre
Copy link
Member

mandre commented Jun 30, 2022

/hold
We've not seen the Cinder CSI job passing yet.

@mandre
Copy link
Member

mandre commented Jun 30, 2022

I'm wondering if the changes to the cinder CSI driver caused the job to flake. I'd like to understand what the failure is before merging.

@EmilienM
Copy link
Member

/retest

1 similar comment
@EmilienM
Copy link
Member

EmilienM commented Jul 4, 2022

/retest

@EmilienM
Copy link
Member

EmilienM commented Jul 4, 2022

results are OK now... still a failure but should be fine. Doing a recheck in case something is too flacky.

/retest

@EmilienM
Copy link
Member

EmilienM commented Jul 4, 2022

this should be fine to merge, the latest errors have been seen in other CI jobs outside this PR.
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2022
@EmilienM
Copy link
Member

EmilienM commented Jul 4, 2022

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 246ae15 and 8 for PR HEAD 6a35fd1 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 246ae15 and 7 for PR HEAD 6a35fd1 in total

@openshift-ci
Copy link

openshift-ci bot commented Jul 5, 2022

@shiftstack-merge-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 6460561 into openshift:master Jul 5, 2022
@EmilienM EmilienM deleted the merge-bot-master branch July 5, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

@EmilienM EmilienM

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet