New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a test for deletion annotations after scale down #150
add a test for deletion annotations after scale down #150
Conversation
/hold i think this test needs a little further examination, i have seen some test failures that i am having trouble tracking down. |
cdb7eb0
to
0d4b7ae
Compare
/hold cancel i've fixed this test to take into account the time involved with resolving the deletion taints from the remaining machines. we expect the annotations will be removed but it is difficult to guarantee /when/ they will be removed. this test will now wait for a short period of time to give the machines extra time to reflect the annotation changes. |
0d4b7ae
to
e3a6907
Compare
adjusted the wait time for the annotations from short to medium. although this test passes locally, i am seeing error in the ci jobs. i have a feeling relaxing the timing here will help. |
/retest |
e3a6907
to
6aaa7bb
Compare
just adding a little more info to the log statements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good, added some suggestions for improvements, LMK if you have any questions
6aaa7bb
to
1eb287c
Compare
updated based on comments. as discussed offline, we will push on the edit: related #154 |
/retest |
/lgtm Needs a BZ if we want this to merge now |
we do have a bz for this, but i was under the impression that we don't need them for this repo. |
/retest |
Tide status seems to me to suggest otherwise 🤔 |
i had thought we didn't need them per our discussion offline, but looking at another recent pr i can see we do. i'll add it. |
@elmiko: This pull request references Bugzilla bug 1820410, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
added the cluster autoscaler event watcher into these tests. this is borrowed from the previous scale up/down test but it is added in a way to be automatic for tests in the same i'm adding this because it has been invaluable in debugging issues with test failures. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
1 similar comment
/retest |
/test e2e-azure-operator |
/retest Please review the full test history for this PR and help us cut down flakes. |
This change adds a new test to the autoscaler suite for detecting annotations that are left on Machines after a scale down to minimum size. To accomplish this, several larger changes were added to the suite. One of the larger changes is that `Context` blocks have been added around the 2 major tests cases. These blocks represent the different ClusterAutoscalers that are used with each testing group. The first test group, namely the "scale up and down" suite, has been left untouched. The second test group, with "scale to/from zero", has been changed to make the ClusterAutoscaler management part of the Before/After clauses for each test. This test is related to bugzilla case 1820410. reference: https://bugzilla.redhat.com/show_bug.cgi?id=1820410
9023238
to
bc47cd7
Compare
rebase to account for other changes. |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
This change adds a test to the autoscale "scale up and down" suite that
will check to see if there are any deletion annotations left on the
machine resources after a scale down. To accomplish this some logic has
been added to make the test wait until the scale down has completed so
that we can check the remaining machines.
This test is related to bugzilla case 1820410. reference:
https://bugzilla.redhat.com/show_bug.cgi?id=1820410