New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OCPCLOUD-936] Bug 1902157: Mark node with condition when due for termination #332
[OCPCLOUD-936] Bug 1902157: Mark node with condition when due for termination #332
Conversation
Skipping CI for Draft Pull Request. |
1f176e4
to
1f9b4b9
Compare
/test all |
1f9b4b9
to
b4a3478
Compare
/test all |
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handler
description should be updated, we are not deleting machine anymore
pkg/termination/handler.go
Outdated
awsTerminationEndpointURL = "http://169.254.169.254/latest/meta-data/spot/termination-time" | ||
awsTerminationEndpointURL = "http://169.254.169.254/latest/meta-data/spot/termination-time" | ||
terminatingConditionType corev1.NodeConditionType = "Terminating" | ||
terminationRequestedReason = "TerminationRequested" | ||
) | ||
|
||
// Handler represents a handler that will run to check the termination |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handler
description should be updated, we are not deleting machine anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need machinev1.AddToScheme(scheme.Scheme)
here https://github.com/openshift/cluster-api-provider-aws/pull/332/files#diff-54d803d59532e93b9587a50da031ea3dL31 ?
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
b4a3478
to
532e5ce
Compare
532e5ce
to
5d0039d
Compare
Switch from deleting the Machine to marking the Node with a `Terminating` condition. This will integrate with an MHC to ensure that the Machine is deleted. This should be possible using the Node's credentials and as such, the termination handler will not need its own credentials and extra permissions
5d0039d
to
48c98a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes sense to me
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@JoelSpeed: This pull request references Bugzilla bug 1902157, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retetst |
/test e2e-aws-operator |
/test e2e-aws-operator |
/test e2e-aws |
3 similar comments
/test e2e-aws |
/test e2e-aws |
/test e2e-aws |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@JoelSpeed: All pull requests linked via external trackers have merged:
Bugzilla bug 1902157 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Switch from deleting the Machine to marking the Node with a
Terminating
condition.This will integrate with an MHC to ensure that the Machine is deleted.
This should be possible using the Node's credentials and as such, the termination handler will not need its own credentials and extra permissions.
Requires openshift/machine-api-operator#627 before it will work