New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1866881: Filter Name/Cluster instance tags #343
Bug 1866881: Filter Name/Cluster instance tags #343
Conversation
@michaelgugino: This pull request references Bugzilla bug 1866881, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@michaelgugino: This pull request references Bugzilla bug 1866881, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rawTagList := []*ec2.Tag{} | ||
for _, tag := range machineTags { | ||
// AWS tags are case sensitive, so we don't need to worry about other casing of "Name" | ||
if !strings.HasPrefix(tag.Name, "kubernetes.io/cluster/") && tag.Name != "Name" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to reserve the whole of kubernetes.io/cluster/*****
? Why not just make sure it's not matching the cluster ID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought about it, and I think we should. Because if someone copied a machineset from another cluster and applied it to one in the same account, bad things could happen.
Currently, users can specify whatever instance tags they want for a machineSpec. While we attempt to remove duplicates, this results in us removing the proper values instead of the user supplied ones. This commit ensures we always set the proper values for Name and cluster tags on instances.
4b12839
to
0e210cb
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-aws-operator |
/retest Please review the full test history for this PR and help us cut down flakes. |
@michaelgugino: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-aws#343. Bugzilla bug 1866881 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently, users can specify whatever instance tags they want
for a machineSpec. While we attempt to remove duplicates,
this results in us removing the proper values instead of
the user supplied ones.
This commit ensures we always set the proper values
for Name and cluster tags on instances.