New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1906740: Ensure the region is valid when creating AWS client #380
Bug 1906740: Ensure the region is valid when creating AWS client #380
Conversation
@JoelSpeed: An error was encountered adding this pull request to the external tracker bugs for bug 1906740 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@JoelSpeed: An error was encountered adding this pull request to the external tracker bugs for bug 1906740 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@JoelSpeed: An error was encountered adding this pull request to the external tracker bugs for bug 1906740 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This seems sensible to me, probably need to test this thoroughly in QE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh |
@JoelSpeed: This pull request references Bugzilla bug 1906740, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JoelSpeed: All pull requests linked via external trackers have merged: Bugzilla bug 1906740 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR ensures that any time we create a client, if the endpoint doesn't resolve to a known standard or custom endpoint, the error returned is an AWS
endpoints.UknownEndpointError
instead of a request error.Currently, the endpoint resolver falls back to constructing an invalid URL when it doesn't know a particular region, this results in request being made and the error returning looking like
Request Error: Unable to resolve host:...
, now the error will correctly be wrapped such that is saysregion "foo" not resolved: Unknown Endpoint: ...
which should hopefully narrow down that the issue is a user input error faster.This doesn't fully resolve the attached bug but will improve the error message to help towards a resolution.