Add providerID annotation to machine object #86
Conversation
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vikaschoudhary16
force-pushed
the
providerID
branch
from
10e1f8a
to
5b82c0e
Compare
| @@ -516,8 +555,12 @@ func (a *Actuator) Update(cluster *clusterv1.Cluster, machine *clusterv1.Machine | |||
| // but instance could be deleted between the two calls. | |||
| if len(instances) == 0 { | |||
| mLog.Warnf("attempted to update machine but no instances found") | |||
| err := a.updateProviderID(machine, nil, mLog) | |||
There was a problem hiding this comment.
Given the provider ID does not change very often, it's fine to update entire machine object followed by updating just its status.
|
@vikaschoudhary16: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-bot
added
the
needs-rebase
|
@vikaschoudhary16: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
As we now do the node <=> machine mapping based on the "machine" annotation on the node I'm closing this as it was trying to provide the same thing. Fixed for the autoscaler in openshift/kubernetes-autoscaler#14 |
Signed-off-by: Vince Prignano <vince@vincepri.com>
This is annotation based solution for https://jira.coreos.com/browse/CLOUD-206 until upstream PR for adding ProviderID in MachineStatus gets merged.
xref:frobware/autoscaler#1