New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1878293: Unpin controller-runtime #110
Bug 1878293: Unpin controller-runtime #110
Conversation
Embed the Manager in managerWrapper instead of composing it. The eliminates the need to redefine every method, which breaks whenever Manager changes.
We were unable to update to controller-runtime v0.6.0 because a new method (AddMetricsExtraHandler()) was added to the Manager interface, and our previous wrapper implementation required us to reimplement every method in the interface. With that changed, this is no longer required and we can update.
/retitle Bug 1878293: Unpin controller-runtime |
@zaneb: This pull request references Bugzilla bug 1878293, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zaneb: All pull requests linked via external trackers have merged: Bugzilla bug 1878293 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add OWNERS file.
Our implementation of managerWrapper was inflexible, and broke when new methods were added to the Manager interface. This forced us to pin controller-runtime to an older version.
Simplify the managerWrapper to eliminate this problem, and unpin the dependency.