Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1878293: Unpin controller-runtime #110

Merged

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented Sep 11, 2020

Our implementation of managerWrapper was inflexible, and broke when new methods were added to the Manager interface. This forced us to pin controller-runtime to an older version.

Simplify the managerWrapper to eliminate this problem, and unpin the dependency.

Embed the Manager in managerWrapper instead of composing it. The
eliminates the need to redefine every method, which breaks whenever
Manager changes.
We were unable to update to controller-runtime v0.6.0 because a new
method (AddMetricsExtraHandler()) was added to the Manager interface,
and our previous wrapper implementation required us to reimplement every
method in the interface. With that changed, this is no longer required
and we can update.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@zaneb
Copy link
Member Author

zaneb commented Sep 11, 2020

/retitle Bug 1878293: Unpin controller-runtime

@openshift-ci-robot openshift-ci-robot changed the title Unpin controller-runtime Bug 1878293: Unpin controller-runtime Sep 11, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 11, 2020
@openshift-ci-robot
Copy link

@zaneb: This pull request references Bugzilla bug 1878293, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1878293: Unpin controller-runtime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 11, 2020
@dhellmann
Copy link

/lgtm
/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7909703 into openshift:master Sep 11, 2020
@openshift-ci-robot
Copy link

@zaneb: All pull requests linked via external trackers have merged:

Bugzilla bug 1878293 has been moved to the MODIFIED state.

In response to this:

Bug 1878293: Unpin controller-runtime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

honza pushed a commit to honza/cluster-api-provider-baremetal that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants