Bug 2009111: Fix broken path defaulting for disk image

[lobziik]

BasePath was changed in GCP sdk. In c6faa4b sdk was updated.

See git diff c6faa4bae2ca201573c628e92b112971833284e7~1..HEAD vendor/google.golang.org/api/compute/v1/compute-gen.go

diff --git a/vendor/google.golang.org/api/compute/v1/compute-gen.go b/vendor/google.golang.org/api/compute/v1/compute-gen.go
index 2f65969c..03fecd97 100644
--- a/vendor/google.golang.org/api/compute/v1/compute-gen.go
+++ b/vendor/google.golang.org/api/compute/v1/compute-gen.go
@@ -1,4 +1,4 @@
-// Copyright 2020 Google LLC.
+// Copyright 2021 Google LLC.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
@@ -78,11 +78,12 @@ var _ = internaloption.WithDefaultEndpoint
 const apiId = "compute:v1"
 const apiName = "compute"
 const apiVersion = "v1"
-const basePath = "https://compute.googleapis.com/compute/v1/projects/"
+const basePath = "https://compute.googleapis.com/compute/v1/"
+const mtlsBasePath = "https://compute.mtls.googleapis.com/compute/v1/"

...

[openshift-ci]

@lobziik: This pull request references Bugzilla bug 2009111, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2009111: Try fix broken path defaulting for disk image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lobziik]

/retest

[openshift-ci]

@lobziik: This pull request references Bugzilla bug 2009111, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2009111: Try fix broken path defaulting for disk image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@lobziik: This pull request references Bugzilla bug 2009111, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2009111: Try fix broken path defaulting for disk image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lobziik]

I updated PR description with my findings, @Fedosin @elmiko PTAL

[lobziik]

/bugzilla refresh

[openshift-ci]

@lobziik: This pull request references Bugzilla bug 2009111, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lobziik]

/bugzilla refresh

[openshift-ci]

@lobziik: This pull request references Bugzilla bug 2009111, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lobziik]

/cherry-pick release-4.9

[openshift-cherrypick-robot]

@lobziik: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@lobziik: This pull request references Bugzilla bug 2009111, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 2009111: Fix broken path defaulting for disk image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elmiko]

seems like the CI failure is related to this change, or is that just he output message?

[elmiko]

/test e2e-gcp-operator

[lobziik]

[36mINFO�[0m[2021-10-01T02:30:45Z] Running step e2e-gcp-operator-test.          
�[36mINFO�[0m[2021-10-01T03:37:25Z] Step e2e-gcp-operator-test succeeded after 1h6m40s. 
�[36mINFO�[0m[2021-10-01T03:37:25Z] Running step e2e-gcp-operator-gather-gcp-console. 
�[36mINFO�[0m[2021-10-01T03:38:05Z] Logs for container test in pod e2e-gcp-operator-gather-gcp-console: 
�[36mINFO�[0m[2021-10-01T03:38:05Z] Activated service account credentials for: [do-not-delete-ci-provisioner@**********************.iam.gserviceaccount.com]
....
Gathering console logs for ci-op-f1ilhvid-41113-5dmtp8k2q4-s4qtk from https://www.googleapis.com/compute/v1/projects/**********************/zones/us-central1-a
ERROR: (gcloud.compute.instances.get-serial-port-output) Could not fetch serial port output: The resource 'projects/**********************/zones/us-central1-a/instances/ci-op-f1ilhvid-41113-5dmtp8k2q4-s4qtk' is not ready
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-10-01T03:37:58Z"}
error: failed to execute wrapped command: exit status 1 
�[36mINFO�[0m[2021-10-01T03:38:05Z] Step e2e-gcp-operator-gather-gcp-console failed after 40s. 
�[36mINFO�[0m[2021-10-01T03:38:05Z] Running step e2e-gcp-operator-gather-must-gather.

Hm... For me this fail does not seem related to this change. Tests was passed.

[lobziik]

/test e2e-gcp-operator

[elmiko]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@lobziik: All pull requests linked via external trackers have merged:

• openshift/cluster-api-provider-gcp#175

Bugzilla bug 2009111 has been moved to the MODIFIED state.

In response to this:

Bug 2009111: Fix broken path defaulting for disk image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@lobziik: #175 failed to apply on top of branch "release-4.9":

Applying: Try fix broken path for rhcos image
Using index info to reconstruct a base tree...
M	pkg/cloud/gcp/actuators/machine/reconciler.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cloud/gcp/actuators/machine/reconciler.go
CONFLICT (content): Merge conflict in pkg/cloud/gcp/actuators/machine/reconciler.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Try fix broken path for rhcos image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.