Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #168

Merged
merged 2 commits into from Sep 14, 2022
Merged

Conversation

engelmi
Copy link

@engelmi engelmi commented Sep 14, 2022

This PR does a few minor (logging) improvements such as

  • fixed logging typo
  • logging errors for node- and providerID-controller on failed oVirt connection
  • remove second .Test() from healthz func
  • updating go-ovirt-client
    (OCPRHV-695)

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@engelmi
Copy link
Author

engelmi commented Sep 14, 2022

/retest

Copy link

@janosdebugs janosdebugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

return ResultRequeueDefault(),
errors.Wrap(err, "error getting connection to oVirt, requeue")
msg := "error getting connection to oVirt, requeuing"
r.Log.Errorf(msg+": %v", err)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use %s for the message? No big problem, but this looks weird.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engelmi, janosdebugs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [engelmi,janosdebugs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 929b76b into openshift:master Sep 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2022

@engelmi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants