Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize operator refactoring #299

Merged
merged 9 commits into from Jul 10, 2020

Conversation

mfojtik
Copy link
Member

@mfojtik mfojtik commented Jul 9, 2020

This is the final refactor PR:

  • The operator2 package is gone
  • Each handler is now separate, independent controller
  • Common code (getters) moved to common package

@mfojtik mfojtik changed the title Refactor handle version to controller Finalize operator refactoring Jul 9, 2020
@mfojtik mfojtik force-pushed the refactor-version branch 4 times, most recently from 4f1b966 to 782de96 Compare July 9, 2020 16:47
@mfojtik mfojtik force-pushed the refactor-version branch 3 times, most recently from 37fda09 to 4f1826c Compare July 10, 2020 07:46
pkg/controllers/targetversion/target_version_controller.go Outdated Show resolved Hide resolved
pkg/controllers/common/ingress_config.go Outdated Show resolved Hide resolved
pkg/controllers/common/route.go Outdated Show resolved Hide resolved
pkg/controllers/deployment/deployment_controller.go Outdated Show resolved Hide resolved
pkg/controllers/deployment/deployment_controller.go Outdated Show resolved Hide resolved
* openshift/api@65661b48: config: add an IPv6DualStackNoUpgrade feature set
* openshift/api@f4bb75a9: config: support for other Azure cloud environments
* openshift/api@ba244061: Bug 1774616: BuildLogOptions has drifted from PodLogOptions
* openshift/api@2ec380d6: Generate etcd CRD
* openshift/api@783740a8: operatoringress/dnsrecord: Add observedGeneration
* openshift/api@07453311: Add keepYoungerThanDuration and deprecate keepYoungerThan
* openshift/api@f7acd840: go mod vendor
* openshift/api@434543a3: add approvers to reviewers
* openshift/api@eb3573d1: add operatorcontrolplane/v1 group
* openshift/api@27d67b6e: enable generation for operatorcontrolplane/v1 group
* openshift/api@0cc9aa6f: generate operatorcontrolplane/v1 group artifacts
* openshift/api@2e67ed5c: Validating duration fields on image registry types
* openshift/api@a22769f6: Update defaultNodeSelector description to clarify its behavior with existing nodeSelectors
* openshift/api@2b4a9173: config/network: Add a service node port range parameter to the network spec
* openshift/api@8a9a8bed: Update generated files and CRD
* openshift/api@569c03db: add a new field to token inactivity timeout that can take time duration
* openshift/api@4874cace: make update
* openshift/library-go@dd57ca95: Add status code to ErrNotV2Registry
* openshift/library-go@e000f963: bump(*): openshift/api
* openshift/library-go@68adfde8: Add helpers to observe the service node port range configuration
* openshift/library-go@d2242f3d: use a hostname in leader election id so we can the leaseholder
* openshift/library-go@ac157133: pin github.com/robfig/cron to v1.1.0
* openshift/library-go@9b0a9462: bump(github.com/robfig)
* openshift/library-go@76d0b5a1: update code after downgrading github.com/robfig/cron
* openshift/library-go@63f1f6b0: factory: handle panic in sync
@@ -27,6 +17,13 @@ import (
"github.com/openshift/library-go/pkg/operator/events"
"github.com/openshift/library-go/pkg/operator/status"
"github.com/openshift/library-go/pkg/operator/v1helpers"
appsv1 "k8s.io/api/apps/v1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

order!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I know why @deads2k hate this comments :-)

@stlaz
Copy link
Member

stlaz commented Jul 10, 2020

/approve
/lgtm
/hold
for the part 3 merge

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@mfojtik
Copy link
Member Author

mfojtik commented Jul 10, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2020
@mfojtik
Copy link
Member Author

mfojtik commented Jul 10, 2020

/refresh

@openshift-merge-robot openshift-merge-robot merged commit 21b4d1f into openshift:master Jul 10, 2020
wking added a commit to wking/cluster-authentication-operator that referenced this pull request Nov 24, 2020
Typos from 6d95db7 (targetversion: refactor handle version and
remove old operator, 2020-07-09, openshift#299).  Fixed with:

  $ sed -i 's/successfull /successful /' $(git grep -l 'successfull ')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants