Bug 1874713: deployment: don't panic when applying deployment fails #332
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@stlaz: This pull request references Bugzilla bug 1874713, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
openshift-ci-robot
added
the
approved
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@stlaz: This pull request references Bugzilla bug 1874713, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
| operatorConfig *operatorv1.Authentication, | ||
| deployment *appsv1.Deployment, | ||
| ) error { | ||
| operatorStatusOutdated := operatorConfig.Status.ObservedGeneration != operatorConfig.Generation || operatorConfig.Status.ReadyReplicas != deployment.Status.UpdatedReplicas |
There was a problem hiding this comment.
why we are not using the generic workload controller for this deployment?
The generic controller is used to deploy the openshift-apiserver and the new oauth-apiserver
|
/lgtm @p0lyn0mial your question is a good one. Would like to hear the answer. Let's fix the panic first though. |
|
/retest |
We don't use it because it only came after we started using the current logic. I bet there are side effects that would need to be solved (setting the operand version, for example, there might be more). It's (probably) not impossible to use the generic workload controller, I just wanted to have this fixed fast. |
|
/lgtm @stlaz sounds like a tech debt Jira or bugzilla (your choice) :-) not urgent. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, stlaz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@stlaz: All pull requests linked via external trackers have merged: Bugzilla bug 1874713 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In case there was an error during
ApplyDeployment, the deployment would benil, the controller would panic never to recover again./assign @mfojtik