New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1887428: add ServiceMonitor for the oauth apiserver #361
Bug 1887428: add ServiceMonitor for the oauth apiserver #361
Conversation
@stlaz: An error was encountered adding this pull request to the external tracker bugs for bug 1887428 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@stlaz: An error was encountered adding this pull request to the external tracker bugs for bug 1887428 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@stlaz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/bugzilla refresh |
@stlaz: This pull request references Bugzilla bug 1887428, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits otherwise look good to me.
kind: Role | ||
metadata: | ||
name: prometheus-k8s | ||
namespace: openshift-oauth-apiserver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this annotation intentionally ignored from all the new resources?
include.release.openshift.io/self-managed-high-availability: "true"
As I understand it, CVO would not create the resource if the annotation was missing in default cluster profile mode. Please correct me if I am wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should still be in. Good catch!
@@ -53,3 +53,46 @@ spec: | |||
selector: | |||
matchLabels: | |||
app: oauth-openshift | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have enough expertise to review this file but I trust you with what you are doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment explaining why specific labels are dropped will really help a person like me who is unfamiliar with these metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I am just as unfamiliar with the metrics as you are. This is copied from the openshift-apiserver operator.
7093cb9
to
1dc66b7
Compare
relabelings: | ||
- action: replace | ||
targetLabel: apiserver | ||
replacement: openshift-oauth-apiserver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, when we have the api dashboard, openshift-oauth-apiserver
will show up as an option and we can view its metrics.
manifests/0000_90_cluster-authentication-operator_02_servicemonitor.yaml
Outdated
Show resolved
Hide resolved
1dc66b7
to
084e60a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stlaz, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@stlaz: All pull requests linked via external trackers have merged: Bugzilla bug 1887428 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.6 |
@stlaz: new pull request created: #396 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.