Skip to content

[release-4.9] Bug 2029504: encryption-controller: sync secrets conditionally #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[release-4.9] Bug 2029504: encryption-controller: sync secrets conditionally #518

wants to merge 2 commits into from

Conversation

@dgrisonnet
Copy link
Member

@dgrisonnet dgrisonnet commented Dec 7, 2021

Backport of #506 to release-4.9.

  1. If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.
    • verified
    • does not apply
  2. The bug has significant impact either through severity, reduction in supportability, or number of users affected.
    • verified
    • does not apply
  3. For branches that are in the Maintenance lifecycle phase:
    • The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out, or
    • The bug is a security related bug
    • Branch not in maintenance mode yet (current release + previous release for 90 days after current GA; everything older is in maintenance)
  4. The severity field of the bug must be set to accurately reflect criticality.
    • verified
  5. The PR was created with the cherry-pick bot OR the PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.
    • verified

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2021

@dgrisonnet: This pull request references Bugzilla bug 2029504, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1982726 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1982726 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @gangwgr

In response to this:

[release-4.9] Bug 2029504: encryption-controller: sync secrets conditionally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gangwgr December 7, 2021 08:51
@dgrisonnet
Copy link
Member Author

dgrisonnet commented Dec 7, 2021

/assign @stlaz

@openshift-ci openshift-ci bot requested review from stlaz and sttts December 7, 2021 08:53
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgrisonnet
To complete the pull request process, please ask for approval from stlaz after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot mentioned this pull request Dec 9, 2021
Merged
9 tasks
@dgrisonnet
bump(library-go,golang,etcd)
da74335 
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@dgrisonnet
encryption-controller: sync secrets conditionally
cb2eed9 
Update the version of library-go to include the latest changes that
allow the encryption controller to synchronize the encryption-config
secret only when the encryption controller should be run. This prevents
the secrets from being unnecessarily deleted in the apiserver namespace
whenever it doesn't exist in the config-managed namespace.

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@dgrisonnet
Copy link
Member Author

dgrisonnet commented Dec 9, 2021

/retest-required

1 similar comment
@dgrisonnet
Copy link
Member Author

dgrisonnet commented Dec 9, 2021

/retest-required

@openshift-ci openshift-ci bot mentioned this pull request Dec 10, 2021
Merged
9 tasks
@dgrisonnet
Copy link
Member Author

dgrisonnet commented Dec 20, 2021

/retest

5 similar comments
@dgrisonnet
Copy link
Member Author

dgrisonnet commented Dec 21, 2021

/retest

@dgrisonnet
Copy link
Member Author

dgrisonnet commented Dec 21, 2021

/retest

@dgrisonnet
Copy link
Member Author

dgrisonnet commented Dec 21, 2021

/retest

@dgrisonnet
Copy link
Member Author

dgrisonnet commented Dec 22, 2021

/retest

@dgrisonnet
Copy link
Member Author

dgrisonnet commented Jan 10, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2022

@dgrisonnet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-upgrade cb2eed9 link true /test e2e-agnostic-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2022

@dgrisonnet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgrisonnet
Copy link
Member Author

dgrisonnet commented Jan 28, 2022

Closing as the changes were made as a side effect of #535

@dgrisonnet dgrisonnet closed this Jan 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

@dgrisonnet: This pull request references Bugzilla bug 2029504. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

[release-4.9] Bug 2029504: encryption-controller: sync secrets conditionally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gangwgr gangwgr Awaiting requested review from gangwgr

@stlaz stlaz Awaiting requested review from stlaz

@sttts sttts Awaiting requested review from sttts

Assignees

@stlaz stlaz

Labels

bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgrisonnet @stlaz