Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 1947293 Add managed provisioning network size validation #164

Merged

Conversation

squidboylan
Copy link
Contributor

Validate that managed ipv6 provisioning networks are no larger than a
/64 due to a dnsmasq limitation, also add some relevant documentation.

@openshift-ci openshift-ci bot requested review from asalkeld and stbenjam June 16, 2021 22:29
api/v1alpha1/provisioning_validation.go Outdated Show resolved Hide resolved
api/v1alpha1/provisioning_validation.go Show resolved Hide resolved
@squidboylan squidboylan force-pushed the provision_cidr_limitations branch 2 times, most recently from a809576 to d36813d Compare June 17, 2021 15:30
@squidboylan
Copy link
Contributor Author

/retest

1 similar comment
@squidboylan
Copy link
Contributor Author

/retest

@asalkeld
Copy link
Contributor

@squidboylan you probably need to do a "make generate"

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2021
@squidboylan
Copy link
Contributor Author

@squidboylan you probably need to do a "make generate"

thanks I was confused as to what was happening.

Validate that managed ipv6 provisioning networks are no larger than a
/64 due to a dnsmasq limitation, also add some relevant documentation.
@asalkeld
Copy link
Contributor

/retest

Copy link
Contributor

@asalkeld asalkeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@sadasu
Copy link
Contributor

sadasu commented Jul 2, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu, squidboylan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7bb8e0d into openshift:master Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants