Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IBM images #105

Merged
merged 1 commit into from Sep 10, 2021

Conversation

rtheis
Copy link
Contributor

@rtheis rtheis commented Aug 16, 2021

No description provided.

@rtheis
Copy link
Contributor Author

rtheis commented Aug 16, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2021
@rtheis
Copy link
Contributor Author

rtheis commented Aug 16, 2021

/assign @JoelSpeed

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this generally looks good to me, need to review it again in comparison to our other providers.

@JoelSpeed
Copy link
Contributor

Changes look good, will need to keep the hold until the IBM provider image is added to the release payload though

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Richard
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2021
@lobziik
Copy link
Contributor

lobziik commented Sep 6, 2021

/retest

@rtheis
Copy link
Contributor Author

rtheis commented Sep 8, 2021

PR has been rebased.

@JoelSpeed
Copy link
Contributor

IBM images should be in the next nightly
/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2021

@rtheis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ccm-install 490f172 link /test e2e-aws-ccm-install
ci/prow/e2e-azure-ccm 490f172 link /test e2e-azure-ccm
ci/prow/e2e-azure 490f172 link /test e2e-azure
ci/prow/e2e-azure-ccm-install 490f172 link /test e2e-azure-ccm-install
ci/prow/e2e-azure-upgrade 490f172 link /test e2e-azure-upgrade
ci/prow/e2e-openstack-ccm 490f172 link /test e2e-openstack-ccm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/hold cancel
/lgtm

IBM images should be in the nightlies now

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 10, 2021
@rtheis
Copy link
Contributor Author

rtheis commented Sep 10, 2021

/retest-required

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 74fc689 into openshift:master Sep 10, 2021
@rtheis rtheis deleted the ibm-ccm-image branch September 10, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants