Bug 2000191: Ensure CCCMO and CCMs adheres to OpenShift recommended leader election #114
Conversation
JoelSpeed
changed the title
openshift-ci
bot
added
bugzilla/severity-medium
|
@JoelSpeed: This pull request references Bugzilla bug 2000191, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| --leader-elect \ | ||
| --leader-elect=true \ | ||
| --leader-elect-lease-duration=137s \ | ||
| --leader-elect-renew-deadline=107s \ |
There was a problem hiding this comment.
CCCMO doesn't have these like leader-elect-renew-deadline and leader-elect-retry-period, these values are taken directly from the code. https://github.com/openshift/cluster-cloud-controller-manager-operator/blob/master/cmd/cloud-config-sync-controller/main.go#L117-L118
|
We also need to consider cloud-config-sync-controller and update durations there as well |
JoelSpeed
force-pushed
the
ccm-leader-election
branch
2 times, most recently
from
d11e056
to
2dd729e
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lobziik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
JoelSpeed
force-pushed
the
ccm-leader-election
branch
from
2dd729e
to
76b6cec
Compare
| LeaseDuration: util.LeaseDuration, | ||
| RenewDeadline: util.RenewDeadline, | ||
| RetryPeriod: util.RetryPeriod, | ||
| ResourceName: "cluster-cloud-controller-manager-leader", |
There was a problem hiding this comment.
Should it be different with operator resource name?
|
I checked couple of test runs, all of them seems failing because of no permissions for lease resource. From CCCMO logs: For config sync controller it is the same. |
JoelSpeed
force-pushed
the
ccm-leader-election
branch
from
76b6cec
to
445bfe3
Compare
|
Nice catch on the RBAC, I had put the wrong namespace down for the operator and config sync controller, should be fixed now |
|
/retest |
|
/lgtm I didn't find anything criminal connected to CCMO/CCMs in CI runs. |
|
/lgtml |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@JoelSpeed: All pull requests linked via external trackers have merged: Bugzilla bug 2000191 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To ensure consistency with other components within OpenShift, this PR enforces (via unit tests) a consistent set of leader election flags which adhere to the guidelines set out in the conentions (https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#handling-kube-apiserver-disruption)