Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alibaba Cloud Provider: fix the path to the binary to match the build… #151

Merged
merged 1 commit into from Dec 4, 2021

Conversation

kwoodson
Copy link
Contributor

@kwoodson kwoodson commented Dec 3, 2021

… from the Dockerfile

Since there has been a small amount of churn there is a mismatch in the name and path of the binary from the Dockerfile.

Here is the corresponding Dockerfile:
https://github.com/openshift/cloud-provider-alibaba-cloud/blob/master/openshift-hack/images/Dockerfile.openshift#L12

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 3, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2021

@kwoodson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ccm-install cfcb4bf link false /test e2e-vsphere-ccm-install
ci/prow/e2e-vsphere-ccm cfcb4bf link false /test e2e-vsphere-ccm
ci/prow/e2e-gcp-ccm cfcb4bf link false /test e2e-gcp-ccm
ci/prow/e2e-azure-upgrade cfcb4bf link false /test e2e-azure-upgrade
ci/prow/e2e-azure-ccm-install cfcb4bf link false /test e2e-azure-ccm-install
ci/prow/e2e-azure-ccm cfcb4bf link false /test e2e-azure-ccm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 85b36f3 into openshift:master Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants