Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2059716: Ensure release version is set on config sync controller #176

Conversation

JoelSpeed
Copy link
Contributor

Follow up to #175, I missed this controller and only added the release version to one of the two controllers in this manager

@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Mar 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2022

@JoelSpeed: This pull request references Bugzilla bug 2059716, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 2059716: Ensure release version is set on config sync controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 3, 2022
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@lobziik
Copy link
Contributor

lobziik commented Mar 3, 2022

/retest

@wking
Copy link
Member

wking commented Mar 4, 2022

openshift/release#26744 should have fixed the The bootstrap machine failed to download the release image on build02 jobs.

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ccm-install c755f31 link false /test e2e-azure-ccm-install
ci/prow/e2e-azure-upgrade c755f31 link false /test e2e-azure-upgrade
ci/prow/e2e-azure-ccm c755f31 link false /test e2e-azure-ccm
ci/prow/e2e-gcp-ccm c755f31 link false /test e2e-gcp-ccm
ci/prow/e2e-openstack-ccm c755f31 link false /test e2e-openstack-ccm
ci/prow/e2e-gcp-ccm-install c755f31 link false /test e2e-gcp-ccm-install

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member

wking commented Mar 4, 2022

e2e-azure-upgrade failed on 46 failures to create the sandbox, but the issue we're trying to fix here looks fixed, with some initial-version flapping clearing up once the target-version comes into the mix:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-cloud-controller-manager-operator/176/pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-azure-upgrade/1499615350587658240/artifacts/e2e-azure-upgrade/openshift-e2e-test/build-log.txt | grep clusteroperator/cloud-controller-manager | tail -n5
Mar 04 06:17:55.460 I clusteroperator/cloud-controller-manager versions: operator 4.11.0-0.ci.test-2022-03-04-051909-ci-op-gdjqfjpj-initial -> 
Mar 04 06:17:55.472 I clusteroperator/cloud-controller-manager versions: operator  -> 4.11.0-0.ci.test-2022-03-04-051909-ci-op-gdjqfjpj-initial
Mar 04 06:18:45.426 I clusteroperator/cloud-controller-manager versions: operator 4.11.0-0.ci.test-2022-03-04-051909-ci-op-gdjqfjpj-initial -> 
Mar 04 06:18:45.440 I clusteroperator/cloud-controller-manager versions: operator  -> 4.11.0-0.ci.test-2022-03-04-051909-ci-op-gdjqfjpj-initial
Mar 04 06:22:18.886 I clusteroperator/cloud-controller-manager versions: operator 4.11.0-0.ci.test-2022-03-04-051909-ci-op-gdjqfjpj-initial -> 4.11.0-0.ci.test-2022-03-04-052257-ci-op-gdjqfjpj-latest

@JoelSpeed
Copy link
Contributor Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit fde5bd7 into openshift:master Mar 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@JoelSpeed: All pull requests linked via external trackers have merged:

Bugzilla bug 2059716 has been moved to the MODIFIED state.

In response to this:

Bug 2059716: Ensure release version is set on config sync controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants