New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2099499: Backport resourceapply changes for being able to recreate daemonsets/deployments #194
Bug 2099499: Backport resourceapply changes for being able to recreate daemonsets/deployments #194
Conversation
…deployments Manually cherry-picked resourceapply related changes from openshift#174 Several commits from this patchset was cherry-picked and then squashed together. Such changes introduces recreation logic for daemonsets/deployments in case if selectors was changed. Also, this contains respective tests changes. Commits which was using for prepare this patch: e1f47b7 1bf44f1 d4b6c3f 5b17fa2 a496360 9429f58 7488432
|
@lobziik: This pull request references Bugzilla bug 2099499, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@JoelSpeed: This pull request references Bugzilla bug 2099499, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@lobziik: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label cherry-pick-approved |
|
@lobziik: All pull requests linked via external trackers have merged: Bugzilla bug 2099499 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manually cherry-picked resourceapply related changes from
#174
Several commits from this patchset was cherry-picked and then squashed together.
Such changes introduces recreation logic for daemonsets/deployments in case if
selectors was changed. Also, this contains respective tests changes.
Commits which was using for prepare this patch:
e1f47b7
1bf44f1
d4b6c3f
5b17fa2
a496360
9429f58
7488432