add empty CRs #34
Merged
add empty CRs #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
unauathorized. This may be workingish /retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
wking
added a commit
to wking/cluster-config-operator
that referenced
this pull request
Apr 12, 2019
This reverts commit f0d4122, openshift#34. I don't know what the connection is, but soon after this PR landed we started seeing many: ClusterOperatorNotAvailable: Cluster operator console has not yet reported success And checking the runs from openshift#34's CI: $ curl -s https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-config-operator/34/pull-ci-openshift-cluster-config-operator-master-e2e-aws/148/ | grep 'Cluster operator console' Apr 11 12:46:40.467 E clusterversion/version changed Failing to True: ClusterOperatorNotAvailable: Cluster operator console has not yet reported success Apr 11 12:46:40.467 E clusterversion/version changed Failing to True: ClusterOperatorNotAvailable: Cluster operator console has not yet reported success $ curl -s https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-config-operator/34/pull-ci-openshift-cluster-config-operator-master-e2e-aws/154/ | grep 'Cluster operator console' Apr 11 14:19:02.495 E clusterversion/version changed Failing to True: ClusterOperatorNotAvailable: Cluster operator console has not yet reported success Apr 11 14:19:02.495 E clusterversion/version changed Failing to True: ClusterOperatorNotAvailable: Cluster operator console has not yet reported success $ curl -s https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-config-operator/34/pull-ci-openshift-cluster-config-operator-master-e2e-aws/159/ | grep 'Cluster operator console' Apr 11 15:43:07.639 E clusterversion/version changed Failing to True: ClusterOperatorNotAvailable: Cluster operator console has not yet reported success Apr 11 15:43:07.639 E clusterversion/version changed Failing to True: ClusterOperatorNotAvailable: Cluster operator console has not yet reported success $ curl -s https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-config-operator/34/pull-ci-openshift-cluster-config-operator-master-e2e-aws/164/ | grep 'Cluster operator console' Apr 11 17:48:05.132 E clusterversion/version changed Failing to True: ClusterOperatorNotAvailable: Cluster operator console has not yet reported success Apr 11 17:55:20.136 E clusterversion/version changed Failing to True: ClusterOperatorNotAvailable: Cluster operator console has not yet reported success Apr 11 17:48:05.132 E clusterversion/version changed Failing to True: ClusterOperatorNotAvailable: Cluster operator console has not yet reported success Apr 11 17:55:20.136 E clusterversion/version changed Failing to True: ClusterOperatorNotAvailable: Cluster operator console has not yet reported success $ curl -s https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-config-operator/34/pull-ci-openshift-cluster-config-operator-master-e2e-aws/167/ | grep 'Cluster operator console' level=fatal msg=&openshift#34;failed to initialize the cluster: Cluster operator console has not yet reported success: timed out waiting for the condition&openshift#34; so this commit seems to be responsible. Revert while we try and figure out why.
Closed
|
The dockerfile changes and file moves actually came into master in #36 . #43 reverts the four empty config resources. Most likely cause is authentication set here: https://github.com/openshift/cluster-authentication-operator/blob/36e2370500a73e638ac5730955f0e287a29f0a85/pkg/operator2/starter.go#L41-L48 , which doesn't reconcile and then causes https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/pkg/operator/configobservation/auth/auth_metadata.go to never set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #15