Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCPCLOUD-1662] Implement Control Plane Machine Set manifest generator #95

Merged
merged 1 commit into from Sep 15, 2022

Conversation

damdo
Copy link
Member

@damdo damdo commented Sep 13, 2022

This PR introduces a cli tool which once given access to an OCP cluster is able to generate the canonical Control Plane Machine Set manifest for that cluster, which cluster admins can apply to start managing the control plane of their clusters through the Control Plane Machine Set Operator.

Env test base testing will follow in a follow up PR.
Docs will follow in a follow up PR.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 13, 2022
@damdo damdo marked this pull request as ready for review September 13, 2022 15:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2022
pkg/cmd/generate/generator.go Show resolved Hide resolved
pkg/cmd/generate/generator.go Outdated Show resolved Hide resolved
pkg/cmd/generate/generator.go Outdated Show resolved Hide resolved
pkg/cmd/generate/generator.go Outdated Show resolved Hide resolved
pkg/cmd/generate/generator.go Outdated Show resolved Hide resolved
pkg/cmd/generate/generator.go Outdated Show resolved Hide resolved
pkg/cmd/generate/generator.go Outdated Show resolved Hide resolved
pkg/cmd/generate/generator.go Outdated Show resolved Hide resolved
pkg/cmd/generate/generator.go Outdated Show resolved Hide resolved
pkg/cmd/generate/generator.go Show resolved Hide resolved
@JoelSpeed
Copy link
Contributor

Changes LGTM, would like to squash before merging

@JoelSpeed
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1fa6ff2 and 2 for PR HEAD 8350d52 in total

@damdo
Copy link
Member Author

damdo commented Sep 14, 2022

/retest-required

1 similar comment
@damdo
Copy link
Member Author

damdo commented Sep 15, 2022

/retest-required

@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-aws-serial

This code change doesn't actually affect the payload, and the serial tests seem to be broken

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2022

@JoelSpeed: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ``

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aws-disruptive
  • ci/prow/e2e-aws-ovn
  • ci/prow/e2e-aws-serial
  • ci/prow/e2e-aws-upgrade
  • ci/prow/fmt
  • ci/prow/generate
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/unit
  • ci/prow/vendor
  • ci/prow/vet
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-disruptive
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-serial
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-upgrade
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-fmt
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-generate
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-images
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-lint
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-unit
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-vendor
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-vet
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/e2e-aws-serial

This code change doesn't actually affect the payload, and the serial tests seem to be broken

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-aws-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial

In response to this:

/override ci/prow/e2e-aws-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2022

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 8350d52 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 287342d into openshift:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants