Bug 1940940: Deploy multiple operand replicas #88
Conversation
openshift-ci
bot
added
the
do-not-merge/hold
|
@bertinatto: This pull request references Bugzilla bug 1940940, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-high
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
bertinatto
force-pushed
the
fix-available-false
branch
from
09a536a
to
242c1df
Compare
bertinatto
force-pushed
the
fix-available-false
branch
from
242c1df
to
c12c963
Compare
|
@bertinatto: This pull request references Bugzilla bug 1940940, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@bertinatto: This pull request references Bugzilla bug 1940940, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel @wking @smarterclayton could you take a look at this approach? |
openshift-ci
bot
removed
the
do-not-merge/hold
bertinatto
changed the title
|
/retest |
bertinatto
changed the title
bertinatto
force-pushed
the
fix-available-false
branch
3 times, most recently
from
a54dfec
to
a309669
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
bertinatto
force-pushed
the
fix-available-false
branch
from
a309669
to
b1c3a86
Compare
bertinatto
changed the title
|
@bertinatto: This pull request references Bugzilla bug 1940940, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bertinatto
force-pushed
the
fix-available-false
branch
2 times, most recently
from
c7b59bf
to
974dd5a
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@bertinatto: This pull request references Bugzilla bug 1940940, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
Currently, we deploy only one replica for both operands (webhook and controller). This apparently leads to the operator going unavailable when draining the node where an operand is running on. With this patch we run multiple replicas of each operand, i.e., 1 replica in single-node control-planes or 2 replicas in multi-node control-planes. Also, we set maxSurge=0 and maxUnavailable=1 to make sure nodes are drained one at a time and to prevent more than one pod running on the same node when nodePorts or hostNetwork are used.
bertinatto
force-pushed
the
fix-available-false
branch
from
974dd5a
to
b4c301e
Compare
|
Fixed
…On Thu, Jun 3, 2021 at 02:10, Jan Šafránek ***@***.***> wrote:
***@***.**** commented on this pull request.
In pkg/operator/starter.go
<#88 (comment)>:
> @@ -65,8 +69,22 @@ func RunOperator(ctx context.Context,
controllerConfig *controllercmd.Controller
versionGetter := status.NewVersionGetter()
+ kubeInformersForNamespaces :=
v1helpers.NewKubeInformersForNamespaces(kubeClient,
operatorNamespace, targetNamespace)
You must start the informers below
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#88 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ2D66FN7OGLFKI7NHGTKLTQ5BJDANCNFSM45GMH3IQ>.
|
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@bertinatto: All pull requests linked via external trackers have merged: Bugzilla bug 1940940 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-csi-snapshot-controller-operator-container-v4.8.0-202311261141.p0.g07b3f81.assembly.stream for distgit ose-cluster-csi-snapshot-controller-operator. |
Currently, we deploy only one replica for both operands (webhook and controller). This apparently leads to the operator going unavailable when draining the node where an operand is running on.
With this patch we run multiple replicas of each operand, i.e., 1 replica in single-node control-planes or 2 replicas in multi-node control-planes.
Also, we set maxSurge=0 and maxUnavailable=1 to make sure nodes are drained one at a time and to prevent more than one pod running on the same node when nodePorts or hostNetwork are used.
CC @openshift/storage