Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1707062: Set terminationMessagePolicy=FallbackToLogsOnError for DNS operator and operands #108

Merged
merged 1 commit into from May 15, 2019

Conversation

pravisankar
Copy link

  • FallbackToLogsOnError termination message policy will tell k8s to use the
    last chunk of container log output if the termination message file is empty
    and the container exited with an error.

More details: https://kubernetes.io/docs/tasks/debug-application-cluster/determine-reason-pod-failure/

…NS operator and operands

- FallbackToLogsOnError termination message policy will tell k8s to use the
last chunk of container log output if the termination message file is empty
and the container exited with an error.

More details: https://kubernetes.io/docs/tasks/debug-application-cluster/determine-reason-pod-failure/
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2019
@Miciah
Copy link
Contributor

Miciah commented May 10, 2019

/lgtm
/hold
Holding for 4.2.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2019
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, pravisankar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah
Copy link
Contributor

Miciah commented May 14, 2019

/hold cancel

1 similar comment
@ironcladlou
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2019
@openshift-merge-robot openshift-merge-robot merged commit 3fa6152 into openshift:master May 15, 2019
@smarterclayton
Copy link
Contributor

I'd like to see this in 4.1.z post GA

/cherrypick release-4.1

@openshift-cherrypick-robot

@smarterclayton: new pull request created: #112

In response to this:

I'd like to see this in 4.1.z post GA

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants