Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1717734: status: add related dnses to operator status #118

Merged
merged 1 commit into from Jun 11, 2019
Merged

Bug 1717734: status: add related dnses to operator status #118

merged 1 commit into from Jun 11, 2019

Conversation

ironcladlou
Copy link
Contributor

@ironcladlou ironcladlou commented Jun 10, 2019 •
edited

Add related dnses to operator status to ensure dnses are captured
by must-gather.

oc adm must-gather output:

$ tree cluster-scoped-resources/operator.openshift.io/dnses/
cluster-scoped-resources/operator.openshift.io/dnses/
└── default.yaml

0 directories, 1 file

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1717734

TODO

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 10, 2019
@ironcladlou
Copy link
Contributor Author

Waiting on dependencies to merge
/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2019
@ironcladlou ironcladlou changed the title Related objects Bug 1717734: status: add related doses to operator status Jun 10, 2019
@openshift-ci-robot
Copy link
Contributor

@ironcladlou: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1717734: status: add related doses to operator status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 10, 2019
@ironcladlou ironcladlou changed the title Bug 1717734: status: add related doses to operator status Bug 1717734: status: add related dnses to operator status Jun 10, 2019
@openshift-ci-robot
Copy link
Contributor

@ironcladlou: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1717734: status: add related dnses to operator status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@ironcladlou: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1717734: status: add related dnses to operator status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 11, 2019
@ironcladlou
status: add related dnses to operator status
c5d88fd 
Add related dnses to operator status to ensure dnses are captured
by must-gather.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2019
@ironcladlou
Copy link
Contributor Author

@Miciah @danehans this is ready to review, thanks!

@ironcladlou
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2019
Miciah
Miciah reviewed Jun 11, 2019
View reviewed changes
pkg/operator/controller/status.go
related := []configv1.ObjectReference{
{
Resource: "namespaces",
Name: "openshift-dns-operator",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tech debt accounting note: This maybe should be r.Namespace.

@Miciah
Copy link
Contributor

Miciah commented Jun 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0bc9917 into openshift:master Jun 11, 2019
@ironcladlou ironcladlou mentioned this pull request Jun 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miciah Miciah Miciah left review comments

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ironcladlou @openshift-ci-robot @Miciah @openshift-merge-robot