Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2020489: Enable metrics for custom upstream resolvers #305

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Nov 10, 2021

Before this change, the operator did not enable the "prometheus" plugin in server blocks for custom upstream resolvers. As a consequence, CoreDNS did not report metrics for upstream resolvers and only reported metrics for the default server block. This change enables the "prometheus" plugin for all server blocks.

  • pkg/operator/controller/controller_dns_configmap.go (corefileTemplate): Add the "prometheus" plugin to server blocks for custom upstream resolvers.
  • pkg/operator/controller/controller_dns_configmap_test.go (TestDesiredDNSConfigmap): Verify that desiredDNSConfigMap enables the "prometheus" plugin for all server blocks.

Before this commit, the operator did not enable the "prometheus" plugin in
server blocks for custom upstream resolvers.  As a consequence, CoreDNS did
not report metrics for upstream resolvers and only reported metrics for the
default server block.  This commit enables the "prometheus" plugin for all
server blocks.

This commit fixes bug 2020489.

https://bugzilla.redhat.com/show_bug.cgi?id=2020489

* pkg/operator/controller/controller_dns_configmap.go (corefileTemplate):
Add the "prometheus" plugin to server blocks for custom upstream resolvers.
* pkg/operator/controller/controller_dns_configmap_test.go
(TestDesiredDNSConfigmap): Verify that desiredDNSConfigMap enables the
"prometheus" plugin for all server blocks.
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2021

@Miciah: This pull request references Bugzilla bug 2020489, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

Bug 2020489: Enable metrics for custom upstream resolvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

@Miciah: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node d5af97f link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frobware
Copy link
Contributor

/lgtm

@frobware
Copy link
Contributor

/skip

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4d323b9 into openshift:master Nov 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

@Miciah: All pull requests linked via external trackers have merged:

Bugzilla bug 2020489 has been moved to the MODIFIED state.

In response to this:

Bug 2020489: Enable metrics for custom upstream resolvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants