New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2020489: Enable metrics for custom upstream resolvers #305
Bug 2020489: Enable metrics for custom upstream resolvers #305
Conversation
Before this commit, the operator did not enable the "prometheus" plugin in server blocks for custom upstream resolvers. As a consequence, CoreDNS did not report metrics for upstream resolvers and only reported metrics for the default server block. This commit enables the "prometheus" plugin for all server blocks. This commit fixes bug 2020489. https://bugzilla.redhat.com/show_bug.cgi?id=2020489 * pkg/operator/controller/controller_dns_configmap.go (corefileTemplate): Add the "prometheus" plugin to server blocks for custom upstream resolvers. * pkg/operator/controller/controller_dns_configmap_test.go (TestDesiredDNSConfigmap): Verify that desiredDNSConfigMap enables the "prometheus" plugin for all server blocks.
@Miciah: This pull request references Bugzilla bug 2020489, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/skip |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 2020489 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Before this change, the operator did not enable the "prometheus" plugin in server blocks for custom upstream resolvers. As a consequence, CoreDNS did not report metrics for upstream resolvers and only reported metrics for the default server block. This change enables the "prometheus" plugin for all server blocks.
pkg/operator/controller/controller_dns_configmap.go
(corefileTemplate
): Add the "prometheus" plugin to server blocks for custom upstream resolvers.pkg/operator/controller/controller_dns_configmap_test.go
(TestDesiredDNSConfigmap
): Verify thatdesiredDNSConfigMap
enables the "prometheus" plugin for all server blocks.