Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] Bug 2086451: fix races in etcdclient #828

Merged
merged 2 commits into from Jul 13, 2022
Merged

[release-4.10] Bug 2086451: fix races in etcdclient #828

merged 2 commits into from Jul 13, 2022

Conversation

tjungblu
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2022

@tjungblu: This pull request references Bugzilla bug 2086451, which is invalid:

  • expected Bugzilla bug 2086451 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.10] Bug 2086451: fix races in etcdclient

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor Author

overriding the bz check, this is already in 4.11 as a897093

@tjungblu tjungblu added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 16, 2022
@tjungblu
Copy link
Contributor Author

/retest-required

@tjungblu
Copy link
Contributor Author

/hold

should also pull in some improvements and tests from #834

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2022
@tjungblu
Copy link
Contributor Author

tjungblu commented Jun 3, 2022

/unhold added the test and the ipv6 updates

@tjungblu
Copy link
Contributor Author

tjungblu commented Jun 3, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2022
@tjungblu
Copy link
Contributor Author

tjungblu commented Jun 3, 2022

/retest-required

2 similar comments
@tjungblu
Copy link
Contributor Author

tjungblu commented Jun 7, 2022

/retest-required

@tjungblu
Copy link
Contributor Author

/retest-required

@hasbro17
Copy link
Contributor

/label backport-risk-assessed
/approve

/retest-required

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2022
@tjungblu
Copy link
Contributor Author

/retest

Elbehery
Elbehery approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@Elbehery Elbehery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

.gitignore
@@ -14,3 +14,5 @@ cluster-etcd-operator

# Log output from telepresence
telepresence.log
# Goland
.idea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs new line here, no ?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, hasbro17, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tjungblu tjungblu added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 12, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 4f1dca6 and 8 for PR HEAD 236af76 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 4f1dca6 and 7 for PR HEAD 236af76 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4f1dca6 and 6 for PR HEAD 236af76 in total

@Elbehery
Copy link
Contributor

/retest-required

4 similar comments
@Elbehery
Copy link
Contributor

/retest-required

@tjungblu
Copy link
Contributor Author

/retest-required

@Elbehery
Copy link
Contributor

/retest-required

@tjungblu
Copy link
Contributor Author

/retest-required

@tjungblu
Copy link
Contributor Author

/retest

@tjungblu
Copy link
Contributor Author

/retest-required

1 similar comment
@tjungblu
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 84e6311 and 5 for PR HEAD 236af76 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

@tjungblu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 1df7588 into openshift:release-4.10 Jul 13, 2022
12 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

@tjungblu: All pull requests linked via external trackers have merged:

Bugzilla bug 2086451 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2086451: fix races in etcdclient

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu tjungblu deleted the cprace410 branch July 27, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elbehery Elbehery Elbehery approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

Assignees

@Elbehery Elbehery

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tjungblu @hasbro17 @openshift-ci-robot @Elbehery