Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor client creation/usage #333

Merged
merged 1 commit into from Aug 1, 2019
Merged

Refactor client creation/usage #333

merged 1 commit into from Aug 1, 2019

Conversation

coreydaley
Copy link
Member

Refactor client creation/usage between the controller and the generator
to reuse already created clients instead of creating so many new ones

@coreydaley
Copy link
Member Author

/assign @adambkaplan

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2019
@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest
unrelated failures/flakes

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Refactor client creation/usage
3264778 
Refactor client creation/usage between the controller and the generator
to reuse already created clients instead of creating so many new ones
@coreydaley
Copy link
Member Author

/assign @ricardomaraschini

@coreydaley
Copy link
Member Author

@adambkaplan bump

adambkaplan
adambkaplan suggested changes Aug 1, 2019
View reviewed changes
pkg/operator/controller.go
configinformers "github.com/openshift/client-go/config/informers/externalversions"
routeset "github.com/openshift/client-go/route/clientset/versioned"
routesetv1 "github.com/openshift/client-go/route/clientset/versioned/typed/route/v1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have unversioned and versioned ClientSets?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The informers needed the versioned ones, and the generators needed the unversioned ones

@adambkaplan
Copy link
Contributor

/lgtm

As a follow-up the generators should use versioned clientsets (if possible)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7fdebc1 into openshift:master Aug 1, 2019
@coreydaley coreydaley deleted the refactor_client_usage branch August 14, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan requested changes

@dmage dmage Awaiting requested review from dmage

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@ricardomaraschini ricardomaraschini

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@coreydaley @adambkaplan @openshift-ci-robot @ricardomaraschini @openshift-merge-robot