Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implementing Proxy CA Bundle validation." #363

Merged
merged 2 commits into from Aug 10, 2019

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Aug 10, 2019

Reverts #342

I don't think there was anything wrong w/ the original PR but the Dockerfile changes didn't get synced to distgit, so it started failing in our ART nightlies. once that issue is resolved, this can be un-reverted.

@wking @ricardomaraschini

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 10, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2019
@bparees bparees force-pushed the revert-342-proxy-ca-bundle-check branch from 9079655 to 0c96cbf Compare August 10, 2019 14:40
@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2019
@bparees
Copy link
Contributor Author

bparees commented Aug 10, 2019

slack discussion here:
https://coreos.slack.com/archives/CEKNRGF25/p1565415755176800

bug for resolving the dockerfile sync issue is here:
https://bugzilla.redhat.com/show_bug.cgi?id=1727080

@bparees
Copy link
Contributor Author

bparees commented Aug 10, 2019 via email

@wking
Copy link
Member

wking commented Aug 10, 2019

e2e-aws had a number of errors. The first was:

Error from server: error dialing backend: remote error: tls: internal error
...
failed: (22.1s) 2019-08-10T15:24:09 "[sig-storage] PersistentVolumes-local  [Volume type: blockfswithoutformat] One pod requesting one prebound PVC should be able to mount volume and write from pod1 [Suite:openshift/conformance/parallel] [Suite:k8s]"

There are a few bugs mentioning similar errors, but they're all closed or verified. We should probably open a new one once we have time to dig in.

@openshift-merge-robot openshift-merge-robot merged commit 4bb1181 into master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants