New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1808426: Release 4 3 revert install config #493
Bug 1808426: Release 4 3 revert install config #493
Conversation
|
/assign @dmage @adambkaplan |
|
@coreydaley: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@coreydaley: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@coreydaley: This pull request references Bugzilla bug 1808426, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@coreydaley: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@coreydaley: This pull request references Bugzilla bug 1808426, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@coreydaley is this to address the conflict we got with the cherrypick-bot? I worry that in our z-streams we have a delta in our bug fixes that have not been fully vetted by QE. |
|
@adambkaplan No, this is to address an install of 4.1 that has been upgraded to 4.2 and then 4.3, the install config information would not have been migrated to the infrastructures config map. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coreydaley The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
That's weird that we have to keep migration hacks from 4.1->4.2 in 4.3. @coreydaley are you sure that we might not have the right infrastructure object in 4.3? |
|
@dmage per this comment from @wking #470 (comment) |
|
@coreydaley please do the revert & fix PR against |
|
/close |
|
@coreydaley: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reverts #470 and applies the same fix that we did for release-4.2 to ignore most events from the kube-system namespace