Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1808426: Release 4 3 revert install config #493

Closed
wants to merge 2 commits into from
Closed

Bug 1808426: Release 4 3 revert install config #493

wants to merge 2 commits into from

Conversation

coreydaley
Copy link
Member

Reverts #470 and applies the same fix that we did for release-4.2 to ignore most events from the kube-system namespace

@coreydaley
Copy link
Member Author

/assign @dmage @adambkaplan

@openshift-ci-robot
Copy link
Contributor

@coreydaley: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Release 4 3 revert install config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coreydaley coreydaley changed the title Release 4 3 revert install config Bugzilla 1808426: Release 4 3 revert install config Mar 13, 2020
@coreydaley
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@coreydaley: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coreydaley coreydaley changed the title Bugzilla 1808426: Release 4 3 revert install config Bug 1808426: Release 4 3 revert install config Mar 13, 2020
@openshift-ci-robot
Copy link
Contributor

@coreydaley: This pull request references Bugzilla bug 1808426, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1808425 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1808425 targets the "4.4.0" release, matching the expected (4.4.0) release
  • bug has dependents

In response to this:

Bug 1808426: Release 4 3 revert install config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 13, 2020
@openshift-ci-robot
Copy link
Contributor

@coreydaley: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bugzilla 1808426: Release 4 3 revert install config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coreydaley
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@coreydaley: This pull request references Bugzilla bug 1808426, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1808425 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1808425 targets the "4.4.0" release, matching the expected (4.4.0) release
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 13, 2020
@adambkaplan
Copy link
Contributor

@coreydaley is this to address the conflict we got with the cherrypick-bot?

I worry that in our z-streams we have a delta in our bug fixes that have not been fully vetted by QE.

@coreydaley
Copy link
Member Author

@adambkaplan No, this is to address an install of 4.1 that has been upgraded to 4.2 and then 4.3, the install config information would not have been migrated to the infrastructures config map.

@coreydaley
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: coreydaley
To complete the pull request process, please assign adambkaplan
You can assign the PR to them by writing /assign @adambkaplan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coreydaley
Copy link
Member Author

/retest

@dmage
Copy link
Member

dmage commented Mar 16, 2020

That's weird that we have to keep migration hacks from 4.1->4.2 in 4.3.

@coreydaley are you sure that we might not have the right infrastructure object in 4.3?

@coreydaley
Copy link
Member Author

@dmage per this comment from @wking #470 (comment)

@adambkaplan
Copy link
Contributor

@coreydaley please do the revert & fix PR against master first, then backport to release-4.3

@coreydaley
Copy link
Member Author

/close

@openshift-ci-robot
Copy link
Contributor

@coreydaley: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants