Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] Bug 1826033: Bootstrap as suspended #523

Merged
merged 1 commit into from Apr 24, 2020
Merged

[release-4.4] Bug 1826033: Bootstrap as suspended #523

merged 1 commit into from Apr 24, 2020

Conversation

coreydaley
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 20, 2020
@openshift-ci-robot
Copy link
Contributor

@coreydaley: This pull request references Bugzilla bug 1825284, which is invalid:

  • expected Bugzilla bug 1825284 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1825284: Bootstrap as suspended

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coreydaley
Copy link
Member Author

/assign @dmage @adambkaplan

@coreydaley
Copy link
Member Author

/retest

@adambkaplan
Copy link
Contributor

/retitle [release-4.4] Bug 1826033: Bootstrap as suspended

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1825284: Bootstrap as suspended [release-4.4] Bug 1826033: Bootstrap as suspended Apr 20, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 20, 2020
@openshift-ci-robot
Copy link
Contributor

@coreydaley: This pull request references Bugzilla bug 1826033, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1825284 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1825284 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

[release-4.4] Bug 1826033: Bootstrap as suspended

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 20, 2020
adambkaplan
adambkaplan approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@coreydaley
Copy link
Member Author

/retest

@coreydaley coreydaley added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@coreydaley
Copy link
Member Author

/retest

2 similar comments
@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@adambkaplan
Copy link
Contributor

/hold

Need to fix the prometheus alerts test.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2020
@adambkaplan
Copy link
Contributor

Patch manager note - needs openshift/origin#24901 to merge first.

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@cuppett
Copy link
Member

cuppett commented Apr 22, 2020

/test e2e-aws

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 23, 2020
@bparees
Copy link
Contributor

bparees commented Apr 23, 2020

@coreydaley please make sure you unhold this the second the origin test changes land.

@bparees
Copy link
Contributor

bparees commented Apr 23, 2020

/hold cancel

@bparees
Copy link
Contributor

bparees commented Apr 23, 2020

/retest

@bparees
Copy link
Contributor

bparees commented Apr 23, 2020

/hold

sorry, thought what this needed merged but it was something else.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sttts
Copy link

sttts commented Apr 24, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 24, 2020
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@coreydaley
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 40eee28 into openshift:release-4.4 Apr 24, 2020
@openshift-ci-robot
Copy link
Contributor

@coreydaley: All pull requests linked via external trackers have merged: openshift/cluster-image-registry-operator#523, openshift/origin#24901. Bugzilla bug 1826033 has been moved to the MODIFIED state.

In response to this:

[release-4.4] Bug 1826033: Bootstrap as suspended

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@dmage dmage Awaiting requested review from dmage

Assignees

@dmage dmage

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@coreydaley @openshift-ci-robot @adambkaplan @cuppett @bparees @openshift-bot @sttts @dmage @openshift-merge-robot