Bug 1873728: publishRecordToZones: Fix status merge #446
Conversation
In publishRecordToZones, when merging the updated status with the input status in order to produce the output status, first make a copy of the input status, and use the copy to avoid mutating the input status. Before this change, publishRecordToZones mutated the input status, and so when the caller compared the input status with the output status, it would always find them to be identical. As a result, the caller never updated the DNSRecord's status in the API, which caused the DNS controller to endlessly retry the update and the ingress controller to report DNSReady=False. * pkg/operator/controller/dns/controller.go (publishRecordToZones): Make a copy of the zone statuses, and pass the copy to mergeStatuses to avoid mutating the original zone statuses that the caller passed in. * pkg/operator/controller/dns/controller_test.go (TestPublishRecordToZonesMergesStatus): Verify that publishRecordToZones does not mutate the status.
openshift-ci-robot
added
the
bugzilla/severity-high
|
@Miciah: This pull request references Bugzilla bug 1873728, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 1873728 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@Miciah: new pull request created: #449 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In
publishRecordToZones, when merging the updated status with the input status in order to produce the output status, first make a copy of the input status, and use the copy to avoid mutating the input status.Before this change,
publishRecordToZonesmutated the input status, and so when the caller compared the input status with the output status, it would always find them to be identical. As a result, the caller never updated the DNSRecord's status in the API, which caused the DNS controller to endlessly retry the update and the ingress controller to reportDNSReady=False.pkg/operator/controller/dns/controller.go(publishRecordToZones): Make a copy of the zone statuses, and pass the copy tomergeStatusesto avoid mutating the original zone statuses that the caller passed in.pkg/operator/controller/dns/controller_test.go(TestPublishRecordToZonesMergesStatus): Verify thatpublishRecordToZonesdoes not mutate the status./cherry-pick release-4.5