Add edge termination to canary route

[jomeier]

This commit adds edge termination to the canary route. If you use an external loadbalancer that redirects all http traffic to https (us in our case) this route will not serve its purpose and the openshift-ingress-operator will be degraded during an upgrade.

Setting it to 'edge' termination should work in all setups.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jomeier
To complete the pull request process, please assign ironcladlou after the PR has been reviewed.
You can assign the PR to them by writing /assign @ironcladlou in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Hi @jomeier. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sgreene570]

Hey @jomeier ! Thanks for raising this bug and creating this patch. I previously did not think about this issue with custom external load balancers. Let me double check that this is the best approach to resolve this issue.

In the meantime, let's see what CI says:
/ok-to-test

[sgreene570]

@jomeier could you run make generate and amend the output to this PR? Thanks!

[jomeier]

/retest

[sgreene570]

@jomeier looks like the canary HTTP probe needs to skip certificate verification for these changes to work.

See https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-ingress-operator/555/pull-ci-openshift-cluster-ingress-operator-master-e2e-aws/1364607874621247488/artifacts/e2e-aws/gather-extra/artifacts/pods/openshift-ingress-operator_ingress-operator-5787998cb9-bzxk4_ingress-operator.log

If it's easiest, I can open a PR with the necessary changes to do so and cherry-pick your commits from here over.

[jomeier]

@jomeier looks like the canary HTTP probe needs to skip certificate verification for these changes to work.

See https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-ingress-operator/555/pull-ci-openshift-cluster-ingress-operator-master-e2e-aws/1364607874621247488/artifacts/e2e-aws/gather-extra/artifacts/pods/openshift-ingress-operator_ingress-operator-5787998cb9-bzxk4_ingress-operator.log

If it's easiest, I can open a PR with the necessary changes to do so and cherry-pick your commits from here over.

Sure @sgreene570 . Do what's necessary to solve this problem, please.

[openshift-ci]

@jomeier: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-operator	d48d62b	link	/test e2e-aws-operator
ci/prow/e2e-upgrade	d48d62b	link	/test e2e-upgrade
ci/prow/e2e-aws	d48d62b	link	/test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sgreene570]

superseded by #556

Thanks again @jomeier

[sgreene570]

/close

[openshift-ci-robot]

@sgreene570: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.