New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop build-machinery-go for patching manifests #687
Drop build-machinery-go for patching manifests #687
Conversation
Replace build-machinery-go with oc patch --local for creating profile-specific manifests in order to avoid depending on build-machinery-go. * Makefile: Drop build-machinery-go and call the new hack/update-profile-manifests.sh and hack/verify-profile-manifests.sh scripts instead. * hack/update-profile-manifests.sh: New file, originally authored by Cesar. Create profile-specific manifests by using oc patch --local to apply the patches from the profile-patches/ directory to the manifests under the manifests/ directory. * hack/verify-profile-manifests.sh: New file, originally authored by Cesar. Verify that the profile-specific manifests that update-profile-manifests.sh generates are up to date. * profile-patches/ibm-cloud-managed/02-deployment.yaml-patch: Rename... * profile-patches/ibm-cloud-managed/02-deployment.yaml.patch: ...to this. * tools/tools.go: Drop build-machinery-go. * go.mod: * go.sum: * manifests/02-deployment-ibm-cloud-managed.yaml: * pkg/manifests/bindata.go: * vendor/*: Regenerate. Co-authored-by: Cesar Wong <cewong@redhat.com>
I tried:
which reported success for both linux and darwin I removed /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@Miciah: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Replace build-machinery-go with
oc patch --local
for creating profile-specific manifests in order to avoid depending on build-machinery-go.Makefile
: Drop build-machinery-go and call the newhack/update-profile-manifests.sh
andhack/verify-profile-manifests.sh
scripts instead.hack/update-profile-manifests.sh
: New file, originally authored by Cesar. Create profile-specific manifests by usingoc patch --local
to apply the patches from theprofile-patches/
directory to the manifests under themanifests/
directory.hack/verify-profile-manifests.sh
: New file, originally authored by Cesar. Verify that the profile-specific manifests thatupdate-profile-manifests.sh
generates are up to date.profile-patches/ibm-cloud-managed/02-deployment.yaml-patch
: Rename...profile-patches/ibm-cloud-managed/02-deployment.yaml.patch
: ...to this.tools/tools.go
: Drop build-machinery-go.go.mod
:go.sum
:manifests/02-deployment-ibm-cloud-managed.yaml
:pkg/manifests/bindata.go
:vendor/*
: Regenerate.See #587 (comment).
Motivated by openshift/build-machinery-go#56.