New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1997226: setDefaultPublishingStrategy: Deep copy, tests #691
Bug 1997226: setDefaultPublishingStrategy: Deep copy, tests #691
Conversation
@Miciah: This pull request references Bugzilla bug 1997226, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@Miciah: This pull request references Bugzilla bug 1997226, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we now "Make a copy of spec.endpointPublishingStrategy" is there a need outside of 4.10 to backport this change?
Otherwise LGTM.
/lgtm |
Make a copy of spec.endpointPublishingStrategy to avoid mutating it, and add unit tests for setDefaultDomain and setDefaultPublishingStrategy. Follow-up to commit 4bfff11. * pkg/operator/controller/ingress/controller.go (setDefaultPublishingStrategy): Use a deep copy of ic.Spec.EndpointPublishingStrategy. * pkg/operator/controller/ingress/controller_test.go (TestSetDefaultDomain) (TestSetDefaultPublishingStrategySetsPlatformDefaults) (TestSetDefaultPublishingStrategyHandlesUpdates): New tests.
49f2526
to
0811575
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 1997226 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Make a copy of
spec.endpointPublishingStrategy
to avoid mutating it, and add unit tests forsetDefaultDomain
andsetDefaultPublishingStrategy
.Follow-up to #681.
pkg/operator/controller/ingress/controller.go
(setDefaultPublishingStrategy
): Use a deep copy ofic.Spec.EndpointPublishingStrategy
.pkg/operator/controller/ingress/controller_test.go
(TestSetDefaultDomain
,TestSetDefaultPublishingStrategySetsPlatformDefaults
,TestSetDefaultPublishingStrategyHandlesUpdates
): New tests.@candita, @miheer