Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1932165: variables in DeprecatedAPIInUse alert's annotations.message are not parsed to existing values #1055

Merged
merged 1 commit into from Apr 15, 2021
Merged

Bug 1932165: variables in DeprecatedAPIInUse alert's annotations.message are not parsed to existing values #1055

merged 1 commit into from Apr 15, 2021

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Mar 2, 2021 •
edited

Alert message template when made to pass the TestYamlCorrectness test, results in an invalid message.
Fixed the template and exclude it from the test.

@sanchezl sanchezl changed the title fix api removed in next release in use alert msg Bug 1932165: variables in DeprecatedAPIInUse alert's annotations.message are not parsed to existing values Mar 2, 2021
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Bugzilla bug 1932165, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1932165: variables in DeprecatedAPIInUse alert's annotations.message are not parsed to existing values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 2, 2021
@sanchezl
Copy link
Contributor Author

sanchezl commented Mar 2, 2021

/retest

1 similar comment
@sanchezl
Copy link
Contributor Author

sanchezl commented Mar 9, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 7, 2021

/test e2e-aws-operator

@openshift-ci-robot
Copy link

@sanchezl: This pull request references Bugzilla bug 1932165, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 1932165: variables in DeprecatedAPIInUse alert's annotations.message are not parsed to existing values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Apr 7, 2021

/lgtm
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanchezl, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 7, 2021
@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

11 similar comments
@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

@sanchezl
Copy link
Contributor Author

sanchezl commented Apr 8, 2021

/retest

@sanchezl
Copy link
Contributor Author

/retest

27 similar comments
@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 8bd1cd9 into openshift:master Apr 15, 2021
@openshift-ci-robot
Copy link

@sanchezl: An error was encountered searching for bug 1932165 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 502 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1932165: variables in DeprecatedAPIInUse alert's annotations.message are not parsed to existing values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sanchezl @openshift-ci-robot @sttts @openshift-bot @openshift-merge-robot