Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1963730: Bump library-go for unrevisioned resourcs #1136

Conversation

sttts
Copy link
Contributor

@sttts sttts commented May 31, 2021

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2021
@sttts sttts changed the title WIP: Bump library-go for unrevisioned resourcs Bug 1963730: WIP: Bump library-go for unrevisioned resourcs May 31, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2021
@sttts sttts changed the title Bug 1963730: WIP: Bump library-go for unrevisioned resourcs WIP: Bug 1963730: Bump library-go for unrevisioned resourcs May 31, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label May 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2021

@sttts: This pull request references Bugzilla bug 1963730, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1963730: WIP: Bump library-go for unrevisioned resourcs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 31, 2021
@openshift-ci openshift-ci bot requested review from deads2k and soltysh May 31, 2021 12:23
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 31, 2021
@sttts
Copy link
Contributor Author

sttts commented May 31, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2021

@sttts: This pull request references Bugzilla bug 1963730, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 31, 2021
@openshift-ci openshift-ci bot requested a review from wangke19 May 31, 2021 12:26
@sttts sttts force-pushed the sttts-staticpod-unrevisioned-resources branch from db9b092 to 46778c5 Compare May 31, 2021 12:35
@sttts sttts changed the title WIP: Bug 1963730: Bump library-go for unrevisioned resourcs Bug 1963730: Bump library-go for unrevisioned resourcs May 31, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2021
@mfojtik
Copy link
Member

mfojtik commented May 31, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2021
@mfojtik
Copy link
Member

mfojtik commented May 31, 2021

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 37de83b into openshift:master May 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2021

@sttts: All pull requests linked via external trackers have merged:

Bugzilla bug 1963730 has been moved to the MODIFIED state.

In response to this:

Bug 1963730: Bump library-go for unrevisioned resourcs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants