Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graceful-termination-duration: reduce to 15s for SNO #1168

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jul 1, 2021

To get under 60s for termination+startup.

We might add a more graceful O(10s) timeout to non-long-running requests during termination as follow-up, if this solution turns out to be too bumpy.

@sttts sttts force-pushed the sttts-sno-15s-graceful-termination-period branch from e9271ea to 6f3c27c Compare July 1, 2021 10:07
@openshift-ci openshift-ci bot requested review from deads2k and soltysh July 1, 2021 10:11
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@sttts: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-single-node 6f3c27c link /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 18bae4f into openshift:master Jul 2, 2021
@hexfusion
Copy link
Contributor

hexfusion commented Jul 2, 2021

/cherry-pick release-4.8

for SNO testing ACM

@openshift-cherrypick-robot

@hexfusion: #1168 failed to apply on top of branch "release-4.8":

Applying: graceful-termination-duration: reduce to 15s for SNO
Using index info to reconstruct a base tree...
M	pkg/operator/configobservation/apiserver/observe_termination_duration.go
M	pkg/operator/configobservation/apiserver/observe_termination_duration_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/configobservation/apiserver/observe_termination_duration_test.go
CONFLICT (content): Merge conflict in pkg/operator/configobservation/apiserver/observe_termination_duration_test.go
Auto-merging pkg/operator/configobservation/apiserver/observe_termination_duration.go
CONFLICT (content): Merge conflict in pkg/operator/configobservation/apiserver/observe_termination_duration.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 graceful-termination-duration: reduce to 15s for SNO
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants