Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-4478: guard controller: set an explicit hostname to avoid name collisions #1416

Merged
merged 3 commits into from Jan 5, 2023
Merged

OCPBUGS-4478: guard controller: set an explicit hostname to avoid name collisions #1416

merged 3 commits into from Jan 5, 2023

Conversation

ingvagabund
Copy link
Member

Backporting #1410

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

@ingvagabund: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-4478: guard controller: set an explicit hostname to avoid name collisions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 13, 2022
@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Jira Issue OCPBUGS-4478, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-3041 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-3041 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @jitendar-singh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backporting #1410

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Member Author

/retest-required

1 similar comment
@tsmetana
Copy link
Member

tsmetana commented Jan 4, 2023

/retest-required

This was referenced Jan 4, 2023
Merged
Merged
@tkashem
Copy link
Contributor

tkashem commented Jan 4, 2023

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 4, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 4, 2023
@gangwgr
Copy link

gangwgr commented Jan 4, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 4, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cefbfbf and 2 for PR HEAD 90e6e07 in total

@ingvagabund
Copy link
Member Author

/retest-required

1 similar comment
@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund
Copy link
Member Author

ingvagabund commented Jan 5, 2023 •
edited

There are no installer pods for KA/KCM on either of the master nodes. Checking KA operator logs there's a lot of

base_controller.go:272] InstallerController reconciliation failed: missing required resources: configmaps: client-ca

Probably due to TargetConfigControllerDegraded: \"configmap/client-ca\": configmap/admin-kubeconfig-client-ca in \"openshift-config\" is malformed: data does not contain any valid RSA or ECDSA certificates".

@ingvagabund ingvagabund mentioned this pull request Jan 5, 2023
Closed
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
soltysh
soltysh approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 57bbb53 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 57bbb53 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 336ffd5 into openshift:release-4.12 Jan 5, 2023
@openshift-ci-robot
Copy link

@ingvagabund: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4478 has been moved to the MODIFIED state.

In response to this:

Backporting #1410

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the sync-library-go-4.12 branch January 6, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@jitendar-singh jitendar-singh Awaiting requested review from jitendar-singh

@deads2k deads2k Awaiting requested review from deads2k

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@soltysh soltysh

@tkashem tkashem

@xingxingxia xingxingxia

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ingvagabund @openshift-ci-robot @tsmetana @tkashem @gangwgr @soltysh @xingxingxia @openshift-merge-robot @wangke19