Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove use of deprecated klog flags #1427

Merged
merged 1 commit into from Jan 9, 2023
Merged

remove use of deprecated klog flags #1427

merged 1 commit into from Jan 9, 2023

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Jan 5, 2023 •
edited

Previously deprecated klog flags will be removed completely in kube 1.26.
Logs of bootstrap pods were previously using the --log-file flag, will be available in the cri-o container logs instead.

@openshift-ci openshift-ci bot requested review from deads2k and sttts January 5, 2023 17:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2023
@tkashem tkashem mentioned this pull request Jan 5, 2023
Merged
soltysh
soltysh approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tkashem
Copy link
Contributor

tkashem commented Jan 5, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@deads2k
Copy link
Contributor

deads2k commented Jan 5, 2023

/lgtm cancel
/hold

This change preserves the file, but now produces the potential for creating an enormous file that will never be rotated and never be replaced. This shouldn't merge in the current fashion.

Also, it didn't build on the revert, so it now conflicts. The revert will always merge, fixes built on top will not have conflict failures like this.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2023
@sanchezl sanchezl changed the title do not clobber bootstrap kas log on restart remove obsolete klog --log-file flag Jan 6, 2023
@sanchezl sanchezl changed the title remove obsolete klog --log-file flag remove use of deprecated klog flags Jan 6, 2023
@sanchezl
Copy link
Contributor Author

sanchezl commented Jan 6, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2023
@tkashem
Copy link
Contributor

tkashem commented Jan 6, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4c316ca and 2 for PR HEAD f58f917 in total

@soltysh
Copy link
Member

soltysh commented Jan 9, 2023

/retest-all

@soltysh
Copy link
Member

soltysh commented Jan 9, 2023

/retest

@soltysh
Copy link
Member

soltysh commented Jan 9, 2023

/lgtm cancel
failure is real

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@deads2k
Copy link
Contributor

deads2k commented Jan 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanchezl, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [deads2k,sanchezl,tkashem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4c316ca and 2 for PR HEAD 6f34ef7 in total

@deads2k deads2k mentioned this pull request Jan 9, 2023
Merged
@deads2k
Copy link
Contributor

deads2k commented Jan 9, 2023

bootkube isn't used in upgrade

/override ci/prow/e2e-aws-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2023

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws-ovn-upgrade

In response to this:

bootkube isn't used in upgrade

/override ci/prow/e2e-aws-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 8f2b86d into openshift:master Jan 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2023

@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 6f34ef7 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 6f34ef7 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@omertuc
Copy link

omertuc commented Feb 10, 2023 •
edited

https://issues.redhat.com/browse/OCPQE-13723

I think a library-go bump to openshift/library-go@86dfb36 is needed here

EDIT: nvm saw #1442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@soltysh soltysh

@tkashem tkashem

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sanchezl @tkashem @deads2k @openshift-ci-robot @soltysh @omertuc @openshift-merge-robot