Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: report the control plane architecture #630

Merged
merged 1 commit into from Oct 30, 2019
Merged

metrics: report the control plane architecture #630

merged 1 commit into from Oct 30, 2019

Conversation

crawford
Copy link
Contributor

We are going to soon start supporting instruction set architectures
other than x86_64/AMD64. This new metric will help use understand how
widely these different architectures are used.

The control plane will very likely always be homogeneous, so this metric
assumes that only a single architecture will be reported. Additionally,
for the foreseeable future, OpenShift will only support homogeneous
clusters, so reporting the architecture of the control plane will be
enough to know the architectures in use by the entire cluster.

We are going to soon start supporting instruction set architectures
other than x86_64/AMD64. This new metric will help use understand how
widely these different architectures are used.

The control plane will very likely always be homogeneous, so this metric
assumes that only a single architecture will be reported. Additionally,
for the foreseeable future, OpenShift will only support homogeneous
clusters, so reporting the architecture of the control plane will be
enough to know the architectures in use by the entire cluster.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2019
@sttts
Copy link
Contributor

sttts commented Oct 30, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit 302efb6 into openshift:master Oct 30, 2019
@crawford crawford deleted the arch branch October 30, 2019 19:36
@smarterclayton
Copy link
Contributor

smarterclayton commented Oct 31, 2019

We already capture node architecture count for master nodes. We should revert this.

@smarterclayton
Copy link
Contributor

We already capture this metric in node_role_os_version_machine:cpu_capacity_cores:sum as label_kubernetes_io_arch which has node role labels as well for master and is reported through telemetry. Opened a revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants