Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1794309: Copy default SCC into release image #725

Merged
merged 1 commit into from Jan 23, 2020

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Jan 22, 2020

Currently the default SCC files in 'manifests' folder are not being
copied into the cvo payload. Copy the default SCC in .json files so
CVO can apply these on the cluster.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2020
@tkashem tkashem changed the title Copy default SCC into release image Bug 1793209: Copy default SCC into release image Jan 22, 2020
@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1793209, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1793209: Copy default SCC into release image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 22, 2020
@tkashem
Copy link
Contributor Author

tkashem commented Jan 22, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1793209, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem
Copy link
Contributor Author

tkashem commented Jan 22, 2020

/bugzilla 1793209

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2020
Currently the default SCC files in 'manifests' folder are not being
copied into the cvo payload. Rename the scc in .json files to .yaml
so that it gets copied.
@mfojtik mfojtik changed the title Bug 1793209: Copy default SCC into release image Bug 1794309: Copy default SCC into release image Jan 23, 2020
@mfojtik
Copy link
Member

mfojtik commented Jan 23, 2020

/lgtm
/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 23, 2020
@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1794309, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1794309: Copy default SCC into release image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@openshift-ci-robot
Copy link

@mfojtik: This pull request references Bugzilla bug 1794309, which is valid.

In response to this:

/lgtm
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit ec0f2a6 into openshift:master Jan 23, 2020
@openshift-ci-robot
Copy link

@tkashem: All pull requests linked via external trackers have merged. Bugzilla bug 1794309 has been moved to the MODIFIED state.

In response to this:

Bug 1794309: Copy default SCC into release image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem
Copy link
Contributor Author

tkashem commented Jan 23, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot

@tkashem: new pull request created: #728

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Feb 20, 2020

@tkashem can we backport this to 4.2, compare https://bugzilla.redhat.com/show_bug.cgi?id=1803956 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants