Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1795617: Remove entirely deprecated alerts #741

Merged
merged 1 commit into from Mar 7, 2020

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Jan 28, 2020

This picks commit from #730 and applies the same pattern to the remaining alerts.

/assign @tnozicka

/cc @lilic @cblecker

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 28, 2020
@openshift-ci-robot
Copy link

@soltysh: This pull request references Bugzilla bug 1793850, which is invalid:

  • expected Bugzilla bug 1793850 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1793850: Update UsingDeprecatedAPIExtensionsV1Beta1 alert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 28, 2020
@soltysh soltysh changed the title Bug 1793850: Update UsingDeprecatedAPIExtensionsV1Beta1 alert Bug 1795617: Update UsingDeprecatedAPIExtensionsV1Beta1 alert Jan 28, 2020
@openshift-ci-robot
Copy link

@soltysh: This pull request references Bugzilla bug 1795617, which is invalid:

  • expected dependent Bugzilla bug 1793850 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1795617: Update UsingDeprecatedAPIExtensionsV1Beta1 alert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

apiserver_request_total{
group="extensions",
version="v1beta1",
resource!~"ingresses|",
Copy link
Contributor

@tnozicka tnozicka Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to add ingress here as well? it is deprecated, just still served upstream

@tnozicka
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@tnozicka
Copy link
Contributor

pls clean the commits, modulo the ingress question it lgtm

@soltysh soltysh force-pushed the bug1793850 branch 2 times, most recently from 0b91f37 to a6de32f Compare January 28, 2020 16:06
@tnozicka
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

version="v1beta1",
client!~"hyperkube/.*|cluster-policy-controller/.*|velero-server/.*"
}[24h]
) > 0
labels:
severity: warning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

severity level is hasn't changed (should be info, not warning)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, that won't change as stated before.
/hold cancel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh I'm confused as here (#730 (review)) you stated that "info" was okay, and I had updated my original PR to reflect this.

Warning alerts should be indicative of the cluster health being degraded in some way, and action is required. In the case of OSD, warning alerts are sent to SREs. This alert is not actionable in this way, and should not be at a warning level. It's a bad experience for RH SREs, and both OSD and OCP customers as it's a piece of information that they should take action before the next minor version upgrade.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like info would work just fine for all known use-cases. Can we go with that, please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that regardless of the severity level it will still show up in the main console view.

Also:

This alert is not actionable in this way, and should not be at a warning level.

Exactly why this is why I think we should reconsider this as it can induce alert fatigue, as it will just be there. Are these all components users can control and migrate away from this client?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh pinging again here - request to move to info level.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh can you please set the severity of these alerts to info rather than warning?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The master PR is about different resource that is still present in Kubernetes.

These ones are already removed in the Kubernetes version we are shipping and we'll drop the hack reenabling them in the next release - so warning seems pretty warranted to me. There should be action taken to hunt down the team using it. I think most of our customer use the clusters internally and care about apps that will stop working after the next upgrade. There is also the other case of clusters like Online where you provision for outside users and don't care about what they run, so I'd just suppress the particular warning there unless there is a better way.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 28, 2020
@soltysh
Copy link
Member Author

soltysh commented Jan 29, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@cblecker
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
@soltysh soltysh changed the title Bug 1795617: Update UsingDeprecatedAPIExtensionsV1Beta1 alert Bug 1795617: Remove entirely deprecated alerts Feb 14, 2020
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member Author

soltysh commented Feb 19, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 19, 2020
@openshift-ci-robot
Copy link

@soltysh: This pull request references Bugzilla bug 1795617, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link
Contributor

bparees commented Feb 20, 2020

skipping this one for approval this week anyway due to the number of other changes already accepted.

@cblecker
Copy link
Member

@knobunc This is a low risk PR (removes a PrometheusRule), and is actively causing customer pain (unfixable, never resolving alert in all 4.3 clusters). Asking for consideration for this week's cherrypick batch per your e-mail.

@shawn-hurley shawn-hurley added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 5, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lilic
Copy link
Contributor

lilic commented Mar 6, 2020

/retest

1 similar comment
@soltysh
Copy link
Member Author

soltysh commented Mar 6, 2020

/retest

@lilic
Copy link
Contributor

lilic commented Mar 6, 2020

The upgrade job does not fail, there is a problem with the test platform, the logs say it passes:

2020/03/06 08:30:46 Container setup in pod e2e-aws-upgrade completed successfully
2020/03/06 09:06:30 Container test in pod e2e-aws-upgrade completed successfully
2020/03/06 09:14:49 Container teardown in pod e2e-aws-upgrade completed successfully
2020/03/06 09:14:49 Pod e2e-aws-upgrade succeeded after 1h18m32s

@lilic
Copy link
Contributor

lilic commented Mar 6, 2020

/retest

now CI should be fixed

@cblecker
Copy link
Member

cblecker commented Mar 6, 2020

/retest

@cblecker
Copy link
Member

cblecker commented Mar 6, 2020

/test e2e-aws-operator-encryption

@cblecker
Copy link
Member

cblecker commented Mar 6, 2020

/test e2e-aws-operator

@openshift-merge-robot openshift-merge-robot merged commit e3b7396 into openshift:release-4.3 Mar 7, 2020
@openshift-ci-robot
Copy link

@soltysh: All pull requests linked via external trackers have merged. Bugzilla bug 1795617 has been moved to the MODIFIED state.

In response to this:

Bug 1795617: Remove entirely deprecated alerts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh deleted the bug1793850 branch March 9, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet