Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1823933: Make default SCCs create-only by CVO #831

Merged
merged 1 commit into from Apr 17, 2020

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Apr 14, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2020
@tkashem tkashem changed the title [WIP] Make default SCCs create-only by CVO [WIP] Bug 1823933: Make default SCCs create-only by CVO Apr 14, 2020
@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1823933, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

[WIP] Bug 1823933: Make default SCCs create-only by CVO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 14, 2020
@tkashem
Copy link
Contributor Author

tkashem commented Apr 14, 2020

(note to self)
This BZ will be used for the cherry-pick to 4.4 https://bugzilla.redhat.com/show_bug.cgi?id=1823934.

@tkashem
Copy link
Contributor Author

tkashem commented Apr 15, 2020

/retest

1 similar comment
@tkashem
Copy link
Contributor Author

tkashem commented Apr 15, 2020

/retest

@tkashem
Copy link
Contributor Author

tkashem commented Apr 15, 2020

/retest

1 similar comment
@tkashem
Copy link
Contributor Author

tkashem commented Apr 15, 2020

/retest

@tkashem tkashem changed the title [WIP] Bug 1823933: Make default SCCs create-only by CVO Bug 1823933: Make default SCCs create-only by CVO Apr 15, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2020
@tkashem
Copy link
Contributor Author

tkashem commented Apr 15, 2020

/cherrypick release-4.4

@openshift-cherrypick-robot

@tkashem: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem
Copy link
Contributor Author

tkashem commented Apr 15, 2020

/retest

1 similar comment
@sttts
Copy link
Contributor

sttts commented Apr 16, 2020

/retest

@sttts
Copy link
Contributor

sttts commented Apr 16, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tkashem
Copy link
Contributor Author

tkashem commented Apr 16, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tkashem
Copy link
Contributor Author

tkashem commented Apr 16, 2020

/retest

2 similar comments
@tkashem
Copy link
Contributor Author

tkashem commented Apr 16, 2020

/retest

@tkashem
Copy link
Contributor Author

tkashem commented Apr 16, 2020

/retest

@tkashem
Copy link
Contributor Author

tkashem commented Apr 16, 2020

/test e2e-aws

1 similar comment
@tkashem
Copy link
Contributor Author

tkashem commented Apr 16, 2020

/test e2e-aws

@tkashem
Copy link
Contributor Author

tkashem commented Apr 16, 2020

/retest

1 similar comment
@tkashem
Copy link
Contributor Author

tkashem commented Apr 16, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tkashem
Copy link
Contributor Author

tkashem commented Apr 17, 2020

/retest

@sttts
Copy link
Contributor

sttts commented Apr 17, 2020

level=error msg="Error: [ERR]: Error building changeset: InvalidChangeBatch: [Tried to create resource record set [name='api.ci-op-28d5rqfx-63f8c.origin-ci-int-aws.dev.rhcloud.com.', type='A'] but it already exists]"

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tkashem
Copy link
Contributor Author

tkashem commented Apr 17, 2020

/retest

1 similar comment
@tkashem
Copy link
Contributor Author

tkashem commented Apr 17, 2020

/retest

@mfojtik
Copy link
Member

mfojtik commented Apr 17, 2020

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-cmd
/override ci/prow/e2e-gcp
/override ci/prow/e2e-gcp-upgrade
/override ci/prow/images
/override ci/prow/unit
/override ci/prow/verify

@openshift-ci-robot
Copy link

@mfojtik: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/e2e-cmd
  • ci/prow/e2e-gcp
  • ci/prow/e2e-gcp-upgrade

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-operator
  • ci/prow/e2e-aws-serial
  • ci/prow/e2e-aws-upgrade
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • tide

In response to this:

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-cmd
/override ci/prow/e2e-gcp
/override ci/prow/e2e-gcp-upgrade
/override ci/prow/images
/override ci/prow/unit
/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Apr 17, 2020

/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-aws-operator
/override ci/prow/images
/override ci/prow/unit
/override ci/prow/verify
/override ci/prow/verify-deps

@mfojtik mfojtik merged commit 1e8b4e0 into openshift:master Apr 17, 2020
@openshift-ci-robot
Copy link

@tkashem: All pull requests linked via external trackers have merged: openshift/cluster-kube-apiserver-operator#831. Bugzilla bug 1823933 has been moved to the MODIFIED state.

In response to this:

Bug 1823933: Make default SCCs create-only by CVO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Apr 17, 2020

/cherrypick release-4.4

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-operator, ci/prow/e2e-aws-upgrade, ci/prow/images, ci/prow/unit, ci/prow/verify, ci/prow/verify-deps

In response to this:

/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-aws-operator
/override ci/prow/images
/override ci/prow/unit
/override ci/prow/verify
/override ci/prow/verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@tkashem: new pull request created: #835

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mfojtik: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/cluster-kube-apiserver-operator\n ! [rejected] cherry-pick-831-to-release-4.4 -> cherry-pick-831-to-release-4.4 (fetch first)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/cluster-kube-apiserver-operator'\nhint: Updates were rejected because the remote contains work that you do\nhint: not have locally. This is usually caused by another repository pushing\nhint: to the same ref. You may want to first integrate the remote changes\nhint: (e.g., 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants