From 844c0ffc371fbcb51449297861fd3b6c730ed753 Mon Sep 17 00:00:00 2001 From: ravisantoshgudimetla Date: Wed, 2 Jun 2021 11:09:54 -0400 Subject: [PATCH] Use appropriate metric for PDB alerts As of now, we are using `kube_poddisruptionbudget_status_expected_pods` metric to decide if the PDB is its limit or it exceeded where as `kube_poddisruptionbudget_status_current_healthy` metric gives the exact number of healthy replicas for a deployment or other workload that can scale. So, changing the alerts to use correct metric so that we don't get unnecessary signals. --- .../0000_90_kube-controller-manager-operator_05_alerts.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/manifests/0000_90_kube-controller-manager-operator_05_alerts.yaml b/manifests/0000_90_kube-controller-manager-operator_05_alerts.yaml index eb487d124..405a1e370 100644 --- a/manifests/0000_90_kube-controller-manager-operator_05_alerts.yaml +++ b/manifests/0000_90_kube-controller-manager-operator_05_alerts.yaml @@ -23,7 +23,7 @@ spec: annotations: message: The pod disruption budget is preventing further disruption to pods because it is at the minimum allowed level. expr: | - max by(namespace, poddisruptionbudget) (kube_poddisruptionbudget_status_expected_pods == kube_poddisruptionbudget_status_desired_healthy) + max by(namespace, poddisruptionbudget) (kube_poddisruptionbudget_status_current_healthy == kube_poddisruptionbudget_status_desired_healthy) for: 15m labels: severity: warning @@ -31,7 +31,7 @@ spec: annotations: message: The pod disruption budget is below the minimum number allowed pods. expr: | - max by (namespace, poddisruptionbudget) (kube_poddisruptionbudget_status_expected_pods < kube_poddisruptionbudget_status_desired_healthy) + max by (namespace, poddisruptionbudget) (kube_poddisruptionbudget_status_current_healthy < kube_poddisruptionbudget_status_desired_healthy) for: 15m labels: severity: critical