Bug 1902307: Let vsphere-legacy-cloud-provider update node objects #631
Conversation
Starting kube 1.24, legacy vsphere cloud-provider requires permission to update nodes in order to set topology related labels. For more info see kubernetes/kubernetes#101028
openshift-ci
bot
added
bugzilla/severity-medium
|
@lobziik: This pull request references Bugzilla bug 1902307, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
requested review from
sunzhaohua2,
ingvagabund and
ravisantoshgudimetla
pkg/operator/starter.go
Outdated
| @@ -104,6 +104,9 @@ func RunOperator(ctx context.Context, cc *controllercmd.ControllerContext) error | |||
| "assets/kube-controller-manager/csr_approver_clusterrolebinding.yaml", | |||
| "assets/kube-controller-manager/gce/cloud-provider-role.yaml", | |||
| "assets/kube-controller-manager/gce/cloud-provider-binding.yaml", | |||
| "assets/kube-controller-manager/vsphere/legacy-cloud-provider-sa.yaml", | |||
There was a problem hiding this comment.
In the GCE case the additional RBAC includes events and service status. Hard something that might bring down a cluster. Though extending the RBACs with node's update/patch might cause trouble. Would it make more sense to deploy the additional RBACs only on vsphere?
|
@lobziik: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, lobziik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@lobziik: All pull requests linked via external trackers have merged: Bugzilla bug 1902307 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Starting kube 1.24, legacy vsphere cloud-provider requires
permission to update nodes in order to set topology related labels.
For more info see kubernetes/kubernetes#101028