Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Drop log flags removed in k8s 1.26" #456

Merged
merged 1 commit into from Jan 5, 2023

Conversation

derekhiggins
Copy link
Contributor

This results in historical log files being wiped on restart

This reverts commit 2d66da3.

This results in historical log files being wiped on restart

This reverts commit 2d66da3.
@openshift-ci openshift-ci bot requested review from mfojtik and soltysh January 5, 2023 17:12
@deads2k
Copy link
Contributor

deads2k commented Jan 5, 2023

/lgtm

no conflicts with other merges, putting master back to right for logging. Fixes can come after.

@deads2k deads2k merged commit 27c983d into openshift:master Jan 5, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023

@derekhiggins: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial fe92091 link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k, derekhiggins
Once this PR has been reviewed and has the lgtm label, please assign knelasevero for approval by writing /assign @knelasevero in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants