New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: drop test-rules from test-unit target #1137
Makefile: drop test-rules from test-unit target #1137
Conversation
With openshift/release#17927 the test-rule target is now its own ci case. No need to run test-rules within the test-unit target anymore. This also adds the test-rules target to the test target for convenience. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, jan--f The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/unhold |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
This either needs a BZ or will need to wait for code thaw. |
Ah right, I think waiting for thaw is reasonable. We just currently run the rules test twice, once in its own target, once in |
/hold |
Unholding since we are past code freeze. /unhold |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@jan--f: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
With openshift/release#17927 the test-rule
target is now its own ci case. No need to run test-rules within the
test-unit target anymore.
This also adds the test-rules target to the test target for convenience.
Signed-off-by: Jan Fajerski jfajersk@redhat.com