Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new development doc for new comers #1369

Merged
merged 1 commit into from Sep 28, 2021

Conversation

sthaha
Copy link
Contributor

@sthaha sthaha commented Sep 8, 2021

Explains:

  • how to run CMO locally
  • Update jsonnet bundles
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@sthaha sthaha force-pushed the dev-docs branch 2 times, most recently from 05f7aa4 to 928f4f2 Compare September 8, 2021 02:29
Comment on lines 68 to 74
jb update
cp lockfile.json backup
# restore the original jsonnet.json file
git checkout -- jsonnet.json # (restore to original)

#apply all changes from backup to lockfile
vimdiff backup lockfile.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you can use git add -p to ease the partial change staging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried it and seen if it is any easier than using a merge tool? I found the git add -p harder to get right.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it to be bit easier.

Documentation/development.md Outdated Show resolved Hide resolved
Documentation/development.md Outdated Show resolved Hide resolved

## Updating vendored jsonnsets

NOTE: `jb update <repo-url>/<jsonnet-subdir>` doesn't seem to work since it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug or is it expected? Is it related to jsonnet-bundler/jsonnet-bundler#142?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could be the issue ... I haven't looked further into it.

When I tried to update just kube-prometheus what I found was that it only updated the kube-prometheus and not any transitive dependencies. E.g. it didn't update the kubernetes-mixin.

This was the workaround that worked.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the same problem is being reported in that issue

What actually seems to be happening for transitive dependencies is that jb is retrieving the versions specified in the jsonnetfile.json in the dependency, rather than our local lock file.

I suggest we set up a ticket and fix this problem. We can still document the workaround temporarily and remove it once the problem with jsonnet-bundler is resolved.

Documentation/development.md Outdated Show resolved Hide resolved
Documentation/development.md Show resolved Hide resolved
@sthaha sthaha force-pushed the dev-docs branch 2 times, most recently from 1c4411c to ec29d3a Compare September 9, 2021 04:53
@sthaha
Copy link
Contributor Author

sthaha commented Sep 9, 2021

/retest

Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative @sthaha!

One thing that could be documented also is when should running kube-prometheus for tests purposes is considered good enough. Running CMO locally takes a lot of time compared to just spinning up a kube-prometheus stack and apply manifests changes, so I think a lot of newcomers could benefit from that and save a lot of time and effort. wdyt?




## Updating vendored jsonnet code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usual way I do it which might be easier is:

cd jsonnet
jb update
# add only the dependencies that you want to update
git add -p -- jsonnetfile.lock.json
git checkout .
git reset HEAD -- jsonnetfile.lock.json
cd ..
make clean; make generate
git add -u

Copy link
Contributor Author

@sthaha sthaha Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem I think I find with git add -p is that finding transitive dependencies of the only package that you want to update could be harder compared to the approach I suggested. E.g. say we want to update only kube-prometheus

  1. jb update
  2. git diff shows the change below
Show `git diff`
diff --git jsonnet/jsonnetfile.lock.json jsonnet/jsonnetfile.lock.json
index 6d5adc26..55b32bff 100644
--- jsonnet/jsonnetfile.lock.json
+++ jsonnet/jsonnetfile.lock.json
@@ -1,202 +1,202 @@
 {
   "version": 1,
   "dependencies": [
     {
       "source": {
         "git": {
           "remote": "https://github.com/brancz/kubernetes-grafana.git",
           "subdir": "grafana"
         }
       },
       "version": "c3b14b24b83cfe9abf1064649d19e2d679f033fb",
       "sum": "YrE4DNQsWgYWs6h0j/FjQETt8xDXdYdsslb1WK7xQEk="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/etcd-io/etcd.git",
           "subdir": "contrib/mixin"
         }
       },
-      "version": "91a5089d17f786d244ce49704774a29faf4e4ed2",
+      "version": "69015027b6164801a0f02f050a92bb1e460d28fa",
       "sum": "5XhYOigrKipOWDbIn9hlrz7JcbelzvJnormxSaup9JI="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/grafana/grafonnet-lib.git",
           "subdir": "grafonnet"
         }
       },
-      "version": "3082bfca110166cd69533fa3c0875fdb1b68c329",
-      "sum": "4/sUV0Kk+o8I+wlYxL9R6EPhL/NiLfYHk+NXlU64RUk="
+      "version": "05fb200ee1a1816fc1b4c522071d5606d8dd71c1",
+      "sum": "mEoObbqbyVaXrHFEJSM2Nad31tOvadzIevWuyNHHBgI="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/grafana/jsonnet-libs.git",
           "subdir": "grafana-builder"
         }
       },
-      "version": "ff22d1d6698573e7cb76228198edfa2b2f632dcc",
+      "version": "578a13a11b01c92e9da46ea539869b0205600b42",
       "sum": "GRf2GvwEU4jhXV+JOonXSZ4wdDv8mnHBPCQ6TUVd+g8="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/ksonnet/ksonnet-lib.git",
           "subdir": ""
         }
       },
       "version": "0d2f82676817bbf9e4acf6495b2090205f323b9f",
       "sum": "h28BXZ7+vczxYJ2sCt8JuR9+yznRtU/iA6DCpQUrtEg=",
       "name": "ksonnet"
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/kubernetes-monitoring/kubernetes-mixin.git",
           "subdir": ""
         }
       },
-      "version": "2b27a09a667091cef74776b690ccceaf55995e29",
-      "sum": "j2jPdrcM3iuaUK+6V9jWn2M3Fapr0KtI8FZ1KQoHIGA="
+      "version": "ff4641bcd83314c955150bea6b147df9ca335c4a",
+      "sum": "oUVGwcCbmdH8qz9B+lbRawI9s23GY9HeW7MwYZRbZ/0="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/kubernetes-monitoring/kubernetes-mixin.git",
           "subdir": "lib/promgrafonnet"
         }
       },
-      "version": "2b27a09a667091cef74776b690ccceaf55995e29",
+      "version": "ff4641bcd83314c955150bea6b147df9ca335c4a",
       "sum": "zv7hXGui6BfHzE9wPatHI/AGZa4A2WKo6pq7ZdqBsps="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/kubernetes/kube-state-metrics.git",
           "subdir": "jsonnet/kube-state-metrics"
         }
       },
-      "version": "d111b6d8e07f8dde1dfe7e688f44242e4aa4f734",
+      "version": "b5228e737dbedef617a8d310430f4fbab8ab6842",
       "sum": "S5qI+PJUdNeYOv76jH5nxwYS9N6U7CRxvyuB1wI4cTE="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/kubernetes/kube-state-metrics.git",
           "subdir": "jsonnet/kube-state-metrics-mixin"
         }
       },
-      "version": "d111b6d8e07f8dde1dfe7e688f44242e4aa4f734",
+      "version": "b5228e737dbedef617a8d310430f4fbab8ab6842",
       "sum": "u8gaydJoxEjzizQ8jY8xSjYgWooPmxw+wIWdDxifMAk="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/openshift/openshift-state-metrics.git",
           "subdir": "jsonnet"
         }
       },
-      "version": "a6c557f455f56e2e406f19f471a49ffc066af610",
+      "version": "0dd6085d7d4c00d70f874794dab93bdc64e6774a",
       "sum": "YbabTSgCAw6v0rzfxU59vWkoJy2RNDC5WQdbDGuZo0U=",
       "name": "openshift-state-metrics"
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/openshift/telemeter.git",
           "subdir": "jsonnet/telemeter"
         }
       },
       "version": "1e97dddbde49e13867733cbf3219f6505d3b083a",
       "sum": "Sm209vnPf0l7otdQvWS2rX376AqnhaIrlWqCpopMPCM=",
       "name": "telemeter-client"
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus-operator/kube-prometheus.git",
           "subdir": "jsonnet/kube-prometheus"
         }
       },
-      "version": "6f744e24a5c75a3f8f631dc966b40177208a21bf",
-      "sum": "cbOPi0ArIyjnDsW289gDieoSvH+ccow1p/uNFiV6zOk="
+      "version": "7f1092cddeae1a50ffa3b1ca5b2fb20a73d8a2f2",
+      "sum": "Ae2vGpIAMj34Vdkr/WE2HLAIpbfvJWctYP82zHmZSfM="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus-operator/prometheus-operator.git",
           "subdir": "jsonnet/mixin"
         }
       },
-      "version": "5fe12e2dbe118a5a3604e3ce2531a14f22848c5f",
+      "version": "af9c197bc89da0428fa3c72645299977fd982390",
       "sum": "6reUygVmQrLEWQzTKcH8ceDbvM+2ztK3z2VBR2K2l+U=",
       "name": "prometheus-operator-mixin"
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus-operator/prometheus-operator.git",
           "subdir": "jsonnet/prometheus-operator"
         }
       },
-      "version": "5fe12e2dbe118a5a3604e3ce2531a14f22848c5f",
-      "sum": "FUGl2HPBXDJQ3W9WeHPDBvATBHODKRAsyTP0G5PtviM="
+      "version": "af9c197bc89da0428fa3c72645299977fd982390",
+      "sum": "sECNXs/aIEreFUma1BWVyknBygqh3AVJEB3msmrAYYY="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus/alertmanager.git",
           "subdir": "doc/alertmanager-mixin"
         }
       },
-      "version": "8da517524a878ee8933ed12376bb997ebaba3a09",
+      "version": "e35efbddb66a73fd8723be5334477e76f21fbd19",
       "sum": "pep+dHzfIjh2SU5pEkwilMCAT/NoL6YYflV4x8cr7vU=",
       "name": "alertmanager"
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus/node_exporter.git",
           "subdir": "docs/node-mixin"
         }
       },
-      "version": "6f1286b314fdf16155928e92d436be0a107ce9c6",
+      "version": "60e9670f1485deeadb8027e16c393d74d0af6594",
       "sum": "OFNs9Te1QMqSscXqNqMv0zwaJoJxaEg7NyQVNyT4VeA="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus/prometheus.git",
           "subdir": "documentation/prometheus-mixin"
         }
       },
-      "version": "c244fe27a323a69d062b5c2c40a52fd15a831b0f",
+      "version": "d77c985f8c122cf5947b0eb621999fcc8dcca9bf",
       "sum": "m4VHwft4fUcxzL4+52lLZG/V5aH5ZEdjaweb88vISL0=",
       "name": "prometheus"
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/thanos-io/kube-thanos.git",
           "subdir": "jsonnet/kube-thanos"
         }
       },
-      "version": "cfd8d7899c6b7f60c7d0afcf6d76489c630e49d5",
-      "sum": "5+zKiscGKif3jxL+AWo3L5Sq+vQEAhtnRkQ4MLyrDHA="
+      "version": "1fe5b3bda19294b7beab0f0e2902e0d65c4b8cb6",
+      "sum": "NZ8WoqtNu3Xyn9wJemVHnEo5vaG4S9IBms3rNlVRNkk="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/thanos-io/thanos.git",
           "subdir": "mixin"
         }
       },
-      "version": "bd134d7a823708fa135e7a6931e76f581be5f879",
+      "version": "a0e24dd8d573810d69ed7fe56a9c3ac00afeaab7",
       "sum": "X+060DnePPeN/87fgj0SrfxVitywTk8hZA9V4nHxl1g="
     }
   ],
   "legacyImports": false
 }
  1. git add -p : What should be cherry-picked isn't easy at all since the transitive dependencies of kube-prometheus isn't clear at all

Contrast that with the approach suggested which is to edit the jsonnnetfile.json to only have the bundle that you want to update and then use git add -p or vimdiff

Which produces the following
diff --git jsonnet/jsonnetfile.lock.json jsonnet/jsonnetfile.lock.json
index 6d5adc26..eead7874 100644
--- jsonnet/jsonnetfile.lock.json
+++ jsonnet/jsonnetfile.lock.json
@@ -1,202 +1,160 @@
 {
   "version": 1,
   "dependencies": [
     {
       "source": {
         "git": {
           "remote": "https://github.com/brancz/kubernetes-grafana.git",
           "subdir": "grafana"
         }
       },
       "version": "c3b14b24b83cfe9abf1064649d19e2d679f033fb",
       "sum": "YrE4DNQsWgYWs6h0j/FjQETt8xDXdYdsslb1WK7xQEk="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/etcd-io/etcd.git",
           "subdir": "contrib/mixin"
         }
       },
-      "version": "91a5089d17f786d244ce49704774a29faf4e4ed2",
+      "version": "69015027b6164801a0f02f050a92bb1e460d28fa",
       "sum": "5XhYOigrKipOWDbIn9hlrz7JcbelzvJnormxSaup9JI="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/grafana/grafonnet-lib.git",
           "subdir": "grafonnet"
         }
       },
-      "version": "3082bfca110166cd69533fa3c0875fdb1b68c329",
-      "sum": "4/sUV0Kk+o8I+wlYxL9R6EPhL/NiLfYHk+NXlU64RUk="
+      "version": "05fb200ee1a1816fc1b4c522071d5606d8dd71c1",
+      "sum": "mEoObbqbyVaXrHFEJSM2Nad31tOvadzIevWuyNHHBgI="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/grafana/jsonnet-libs.git",
           "subdir": "grafana-builder"
         }
       },
-      "version": "ff22d1d6698573e7cb76228198edfa2b2f632dcc",
+      "version": "578a13a11b01c92e9da46ea539869b0205600b42",
       "sum": "GRf2GvwEU4jhXV+JOonXSZ4wdDv8mnHBPCQ6TUVd+g8="
     },
-    {
-      "source": {
-        "git": {
-          "remote": "https://github.com/ksonnet/ksonnet-lib.git",
-          "subdir": ""
-        }
-      },
-      "version": "0d2f82676817bbf9e4acf6495b2090205f323b9f",
-      "sum": "h28BXZ7+vczxYJ2sCt8JuR9+yznRtU/iA6DCpQUrtEg=",
-      "name": "ksonnet"
-    },
     {
       "source": {
         "git": {
           "remote": "https://github.com/kubernetes-monitoring/kubernetes-mixin.git",
           "subdir": ""
         }
       },
-      "version": "2b27a09a667091cef74776b690ccceaf55995e29",
-      "sum": "j2jPdrcM3iuaUK+6V9jWn2M3Fapr0KtI8FZ1KQoHIGA="
+      "version": "ff4641bcd83314c955150bea6b147df9ca335c4a",
+      "sum": "oUVGwcCbmdH8qz9B+lbRawI9s23GY9HeW7MwYZRbZ/0="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/kubernetes-monitoring/kubernetes-mixin.git",
           "subdir": "lib/promgrafonnet"
         }
       },
-      "version": "2b27a09a667091cef74776b690ccceaf55995e29",
+      "version": "ff4641bcd83314c955150bea6b147df9ca335c4a",
       "sum": "zv7hXGui6BfHzE9wPatHI/AGZa4A2WKo6pq7ZdqBsps="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/kubernetes/kube-state-metrics.git",
           "subdir": "jsonnet/kube-state-metrics"
         }
       },
-      "version": "d111b6d8e07f8dde1dfe7e688f44242e4aa4f734",
+      "version": "b5228e737dbedef617a8d310430f4fbab8ab6842",
       "sum": "S5qI+PJUdNeYOv76jH5nxwYS9N6U7CRxvyuB1wI4cTE="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/kubernetes/kube-state-metrics.git",
           "subdir": "jsonnet/kube-state-metrics-mixin"
         }
       },
-      "version": "d111b6d8e07f8dde1dfe7e688f44242e4aa4f734",
+      "version": "b5228e737dbedef617a8d310430f4fbab8ab6842",
       "sum": "u8gaydJoxEjzizQ8jY8xSjYgWooPmxw+wIWdDxifMAk="
     },
-    {
-      "source": {
-        "git": {
-          "remote": "https://github.com/openshift/openshift-state-metrics.git",
-          "subdir": "jsonnet"
-        }
-      },
-      "version": "a6c557f455f56e2e406f19f471a49ffc066af610",
-      "sum": "YbabTSgCAw6v0rzfxU59vWkoJy2RNDC5WQdbDGuZo0U=",
-      "name": "openshift-state-metrics"
-    },
-    {
-      "source": {
-        "git": {
-          "remote": "https://github.com/openshift/telemeter.git",
-          "subdir": "jsonnet/telemeter"
-        }
-      },
-      "version": "1e97dddbde49e13867733cbf3219f6505d3b083a",
-      "sum": "Sm209vnPf0l7otdQvWS2rX376AqnhaIrlWqCpopMPCM=",
-      "name": "telemeter-client"
-    },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus-operator/kube-prometheus.git",
           "subdir": "jsonnet/kube-prometheus"
         }
       },
-      "version": "6f744e24a5c75a3f8f631dc966b40177208a21bf",
-      "sum": "cbOPi0ArIyjnDsW289gDieoSvH+ccow1p/uNFiV6zOk="
+      "version": "7f1092cddeae1a50ffa3b1ca5b2fb20a73d8a2f2",
+      "sum": "Ae2vGpIAMj34Vdkr/WE2HLAIpbfvJWctYP82zHmZSfM="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus-operator/prometheus-operator.git",
           "subdir": "jsonnet/mixin"
         }
       },
-      "version": "5fe12e2dbe118a5a3604e3ce2531a14f22848c5f",
+      "version": "af9c197bc89da0428fa3c72645299977fd982390",
       "sum": "6reUygVmQrLEWQzTKcH8ceDbvM+2ztK3z2VBR2K2l+U=",
       "name": "prometheus-operator-mixin"
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus-operator/prometheus-operator.git",
           "subdir": "jsonnet/prometheus-operator"
         }
       },
-      "version": "5fe12e2dbe118a5a3604e3ce2531a14f22848c5f",
-      "sum": "FUGl2HPBXDJQ3W9WeHPDBvATBHODKRAsyTP0G5PtviM="
+      "version": "af9c197bc89da0428fa3c72645299977fd982390",
+      "sum": "sECNXs/aIEreFUma1BWVyknBygqh3AVJEB3msmrAYYY="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus/alertmanager.git",
           "subdir": "doc/alertmanager-mixin"
         }
       },
-      "version": "8da517524a878ee8933ed12376bb997ebaba3a09",
+      "version": "e35efbddb66a73fd8723be5334477e76f21fbd19",
       "sum": "pep+dHzfIjh2SU5pEkwilMCAT/NoL6YYflV4x8cr7vU=",
       "name": "alertmanager"
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus/node_exporter.git",
           "subdir": "docs/node-mixin"
         }
       },
-      "version": "6f1286b314fdf16155928e92d436be0a107ce9c6",
+      "version": "60e9670f1485deeadb8027e16c393d74d0af6594",
       "sum": "OFNs9Te1QMqSscXqNqMv0zwaJoJxaEg7NyQVNyT4VeA="
     },
     {
       "source": {
         "git": {
           "remote": "https://github.com/prometheus/prometheus.git",
           "subdir": "documentation/prometheus-mixin"
         }
       },
-      "version": "c244fe27a323a69d062b5c2c40a52fd15a831b0f",
+      "version": "d77c985f8c122cf5947b0eb621999fcc8dcca9bf",
       "sum": "m4VHwft4fUcxzL4+52lLZG/V5aH5ZEdjaweb88vISL0=",
       "name": "prometheus"
     },
-    {
-      "source": {
-        "git": {
-          "remote": "https://github.com/thanos-io/kube-thanos.git",
-          "subdir": "jsonnet/kube-thanos"
-        }
-      },
-      "version": "cfd8d7899c6b7f60c7d0afcf6d76489c630e49d5",
-      "sum": "5+zKiscGKif3jxL+AWo3L5Sq+vQEAhtnRkQ4MLyrDHA="
-    },
     {
       "source": {
         "git": {
           "remote": "https://github.com/thanos-io/thanos.git",
           "subdir": "mixin"
         }
       },
-      "version": "bd134d7a823708fa135e7a6931e76f581be5f879",
-      "sum": "X+060DnePPeN/87fgj0SrfxVitywTk8hZA9V4nHxl1g="
+      "version": "a0e24dd8d573810d69ed7fe56a9c3ac00afeaab7",
+      "sum": "X+060DnePPeN/87fgj0SrfxVitywTk8hZA9V4nHxl1g=",
+      "name": "thanos-mixin"
     }
   ],
   "legacyImports": false
 }

The we only need to git add -p the lines with - and + but I prefer vimdiff (or a mergetool) to compare the original vs the updated and apply only the what is needed .. E.g. the last diff above

-      "version": "bd134d7a823708fa135e7a6931e76f581be5f879",
-      "sum": "X+060DnePPeN/87fgj0SrfxVitywTk8hZA9V4nHxl1g="
+      "version": "a0e24dd8d573810d69ed7fe56a9c3ac00afeaab7",
+      "sum": "X+060DnePPeN/87fgj0SrfxVitywTk8hZA9V4nHxl1g=",
+      "name": "thanos-mixin"

it isn't quite clear to me why name: thanos-mixin is a +

@sthaha
Copy link
Contributor Author

sthaha commented Sep 23, 2021

@dgrisonnet

One thing that could be documented also is when should running kube-prometheus for tests purposes is considered good enough.

I am not entirely sure when this should be done. For almost all work I have done until now (except for prometheus), I have been using CMO explicitly. Could you shed some light into this? It would also be great if we could capture as a todo in jira issue or GH issue so that we can close this PR.

Copy link
Contributor

@arajkumar arajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time of writing this! One small typo spotted otherwise I think it's good enough to be merged and we can still improve further.

Documentation/development.md Outdated Show resolved Hide resolved
Explains:
*  how to run CMO locally
*  Update jsonnet bundles

Signed-off-by: Sunil Thaha <sthaha@redhat.com>
@simonpasquier
Copy link
Contributor

/lgtm
/hold
@dgrisonnet feel free to remove the hold if you're happy with the current change

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arajkumar, simonpasquier, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [arajkumar,simonpasquier,sthaha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor

/label px-approved
/label qe-approved
/label docs-approved

this change has no user impact since this documentation targets only developers contributing to this repository.

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Sep 27, 2021
@dgrisonnet
Copy link
Member

All good from my side 🚀

I'll have a look at adding some information related to kube-prometheus later on, but I wouldn't block this PR based on that.

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

23 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2021

@sthaha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 7595595 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 857ad6c into openshift:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants